Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chart cluster version probe (NR-281093) #1471

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kang-makes
Copy link
Contributor

@kang-makes kang-makes commented Sep 3, 2024

Is this a new chart

Still redacting the PR.

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])

@paologallinaharbur
Copy link
Member

I would isolate changes for this PR

@kang-makes
Copy link
Contributor Author

You are right. When I found that the issue was the pipeline I simply changed branch name, pushed and created a new PR.

I'll rebase it removing all commits except the version probe ASAP

@kang-makes kang-makes force-pushed the kang-makes/add-chart-cluster-version-probe/NR-281093 branch from cad0676 to 297d596 Compare September 5, 2024 08:31
@kang-makes kang-makes marked this pull request as ready for review September 5, 2024 08:32
@kang-makes kang-makes requested review from a team September 5, 2024 08:32
@kang-makes kang-makes requested a review from a team as a code owner September 5, 2024 08:32
@kang-makes kang-makes force-pushed the kang-makes/add-chart-cluster-version-probe/NR-281093 branch from 297d596 to 81ffeac Compare September 5, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants