Skip to content

[super-agent] [FB] chore!: remove default sub-agent #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 3, 2024

Conversation

gsanchezgavier
Copy link
Contributor

@gsanchezgavier gsanchezgavier commented Nov 20, 2024

What this PR does / why we need it:

  • Adds rbac to handle secrets
  • Remove default sub-agent
  • Simplify rbac

Special notes for your reviewer:

Look at checklist before merge!!!

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • AC has been released and updated in this PR with the latest nrdot agent type
  • Chart Version bumped

@gsanchezgavier gsanchezgavier changed the title [super-agent] [FB] chore: remove deprecated nrdot defaults [super-agent] [FB] chore!: remove default sub-agent Nov 20, 2024
@paologallinaharbur
Copy link
Member

[ ] Guided install have been released with nrdot as default @josemore

I do not think this is a blocker since we are pinning the chart version in the UI
https://source.datanerd.us/nr1-dev-experience/shared-component-framework-configs/blob/c7cfed93c19fc1a7131d01d2d663f77fde6bbb7d/shared-component/configs/data-sources/super-agent/config.yml#L973

@gsanchezgavier gsanchezgavier requested review from a team as code owners December 2, 2024 15:45
@gsanchezgavier gsanchezgavier force-pushed the gsanchez/feat/normalize-nrdot-agent-type branch from 716c095 to 012c5be Compare December 2, 2024 15:48
@gsanchezgavier gsanchezgavier force-pushed the gsanchez/feat/normalize-nrdot-agent-type branch from 012c5be to 6f3da5d Compare December 2, 2024 15:50
Copy link
Member

@paologallinaharbur paologallinaharbur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comments regarding the comment in the values.yaml

@gsanchezgavier gsanchezgavier merged commit 050d7ab into master Dec 3, 2024
11 checks passed
@gsanchezgavier gsanchezgavier deleted the gsanchez/feat/normalize-nrdot-agent-type branch December 3, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants