[newrelic-logging] Allow node access rbac config #1724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional permissions required by Fluent Bit's Use_Kubelet On setting. Borrowed from https://github.com/fluent/helm-charts/blob/e2f8ffbd6a98923db67716e4efd98791cb99906d/charts/fluent-bit/values.yaml#L32
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart
No
What this PR does / why we need it:
Adds the additional permissions required to access Kubelet, in order to make use of the Use_Kubelet On setting in the Kubernetes filter. The additional permissions required are documented in (Fluent Bit Kubernetes filter docs)[https://docs.fluentbit.io/manual/pipeline/filters/kubernetes#configuration-setup]. This brings the newrelic-logging chart in line with the option in the Fluent Bit Helm chart.
Which issue this PR fixes
Happy to raise one if required, but hopefully clear enough from the description and the fact it's in the fluent bit chart already.
Special notes for your reviewer:
We're still using this on a fork of the charts. It'd be good to not have to fork the chart to fix this since it adds complexity to upgrades. Previously raised here #569, not sure why it was closed, still seems pretty useful for anyone using the kubernetes filter with
Use_Kubelet On. The alternative is forking the chart or using the fluent bit chart.We set this to alleviate load on the api server, as described in https://docs.fluentbit.io/manual/pipeline/filters/kubernetes. Setting this requires
nodesandnodes/proxy.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])