Skip to content

[agent-control-bootstrap] feat: make cd release name empty when cd is disabled #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielorihuela merged 2 commits into from
Dec 4, 2025
Merged

[agent-control-bootstrap] feat: make cd release name empty when cd is disabled #2018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
306ce45
feat: make cd release name empty when cd is disabled
danielorihuela Nov 25, 2025
45e03f0
Merge branch 'master' into feat/make-cd-release-name-empty-when-cd-is…
danielorihuela Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/agent-control-bootstrap/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: agent-control-bootstrap
description: Bootstraps New Relic' Agent Control

type: application
version: 1.0.7
version: 1.0.8
# agent-control-deployment chart default version.
appVersion: 1.0.6
annotations:
Expand Down
2 changes: 1 addition & 1 deletion charts/agent-control-bootstrap/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ overrides:
{{- if .Values.agentControlCd.enabled -}}
{{- $config = mustMergeOverwrite $config (dict "config" (dict "cdReleaseName" .Values.agentControlCd.releaseName)) -}}
{{- else -}}
{{- $config = mustMergeOverwrite $config (dict "config" (dict "cdRemoteUpdate" false)) -}}
{{- $config = mustMergeOverwrite $config (dict "config" (dict "cdRemoteUpdate" false "cdReleaseName" "")) -}}
{{- end -}}

{{- $config | toYaml | b64enc -}}
Expand Down
7 changes: 5 additions & 2 deletions charts/agent-control-bootstrap/tests/ac_deployment_secret_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ tests:
cdReleaseName: agent-control-cd
subAgentsNamespace: newrelic

- it: should set cdRemoteUpdate as false when agentControlCd is disabled
- it: should set cdRemoteUpdate as false and cdReleaseName as empty when agentControlCd is disabled
set:
agentControlCd:
enabled: false
Expand All @@ -25,15 +25,17 @@ tests:
path: data["agent-control-deployment.yaml"]
value: |-
config:
cdReleaseName: ""
cdRemoteUpdate: false
subAgentsNamespace: newrelic

- it: should override cdRemoteUpdate when agentControlCd is disabled
- it: should override cdRemoteUpdate and cdReleaseName when agentControlCd is disabled
set:
agentControlDeployment:
chartValues:
config:
cdRemoteUpdate: true
cdReleaseName: "name-to-override"
extraNestedValues: unchanged
extraValues: unchanged
agentControlCd:
Expand All @@ -45,6 +47,7 @@ tests:
path: data["agent-control-deployment.yaml"]
value: |-
config:
cdReleaseName: ""
cdRemoteUpdate: false
extraNestedValues: unchanged
extraValues: unchanged
Expand Down
Loading