Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nr 351326 linux prerelease fips #1976

Open
wants to merge 1 commit into
base: feat/fips
Choose a base branch
from
Open

Nr 351326 linux prerelease fips #1976

wants to merge 1 commit into from
+49 −11

Conversation

alvarocabanas
Copy link
Contributor

Add the fips creation and publishing for linux fips.

The steps for docker image creation and testing are commented for testing purposes.

Until we merge dest_prefix is pointing to a custom bucket.

@rajrohanyadav rajrohanyadav force-pushed the feat/fips branch 2 times, most recently from 26aeb17 to 8869d88 Compare December 30, 2024 12:34
@coveralls
Copy link

coveralls commented Dec 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12583575383

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.008%) to 57.328%
Files with Coverage Reduction New Missed Lines %
pkg/metrics/sampler/sampler_routine.go 2 95.35%
pkg/integrations/legacy/runner.go 6 77.96%
Totals Coverage Status
Change from base Build 12546605501: -0.008%
Covered Lines: 15360
Relevant Lines: 26793
💛 - Coveralls

@alvarocabanas alvarocabanas force-pushed the NR_351326_linux_prerelease_fips branch 6 times, most recently from 3023f71 to 01e0832 Compare December 31, 2024 16:31
@alvarocabanas alvarocabanas marked this pull request as ready for review December 31, 2024 16:32
@alvarocabanas alvarocabanas requested a review from a team as a code owner December 31, 2024 16:32
@alvarocabanas alvarocabanas force-pushed the NR_351326_linux_prerelease_fips branch 3 times, most recently from 98df1f2 to 7d6dcfb Compare January 2, 2025 12:08
@alvarocabanas alvarocabanas force-pushed the NR_351326_linux_prerelease_fips branch from 7d6dcfb to f4c20a7 Compare January 2, 2025 14:01
rajrohanyadav
rajrohanyadav reviewed Jan 3, 2025
View reviewed changes
.github/workflows/component_linux_packaging.yml
@@ -32,6 +36,7 @@ env:
DOCKER_HUB_ID: ${{ secrets.DOCKER_HUB_ID }}
DOCKER_HUB_PASSWORD: ${{ secrets.DOCKER_HUB_PASSWORD }}
ARCH: ${{ inputs.ARCH }}
FIPS: ${{ inputs.FIPS == true && '-fips' || '' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit confused with these conditions.

rajrohanyadav
rajrohanyadav approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@rajrohanyadav rajrohanyadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajrohanyadav rajrohanyadav rajrohanyadav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alvarocabanas @coveralls @rajrohanyadav