Skip to content

Conversation

@danielstokes
Copy link
Contributor

@danielstokes danielstokes commented Nov 6, 2025

Description

add support for entity guid in the health from the health sidecar, listing them in the CR

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@danielstokes danielstokes requested a review from a team as a code owner November 6, 2025 22:06
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 71.55963% with 124 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.51%. Comparing base (9644da1) to head (d2c75ed).

Files with missing lines Patch % Lines
api/v1beta3/instrumentation_webhook.go 43.63% 40 Missing and 22 partials ⚠️
cmd/main.go 55.17% 36 Missing and 3 partials ⚠️
api/v1beta3/image_selector.go 71.42% 4 Missing and 4 partials ⚠️
api/v1beta3/name_selector.go 71.42% 4 Missing and 4 partials ⚠️
api/v1beta3/env_selector.go 75.00% 3 Missing and 3 partials ⚠️
internal/instrumentation/health.go 96.42% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
- Coverage   69.54%   68.51%   -1.04%     
==========================================
  Files          46       53       +7     
  Lines        2840     3398     +558     
==========================================
+ Hits         1975     2328     +353     
- Misses        697      850     +153     
- Partials      168      220      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

TmNguyen12
TmNguyen12 previously approved these changes Dec 2, 2025
@danielstokes danielstokes merged commit f7f7b2d into main Dec 5, 2025
18 checks passed
@danielstokes danielstokes deleted the feat-entity-guid branch December 5, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants