feat: send byof status #1899
Merged
feat: send byof status #1899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielorihuela
force-pushed
the
feat/send-byof-status
branch
from
f2b5b6e to
06dffd2
Compare
danielorihuela
commented
Nov 26, 2025
sigilioso
reviewed
Nov 27, 2025
Contributor
sigilioso
left a comment
sigilioso
left a comment
There was a problem hiding this comment.
When the attribute names are clear the changes LGTM, although I'd like us to clarify the comment below 🙂
danielorihuela
dismissed stale reviews from sigilioso and MunhozThiago
via
2009fe6
sigilioso
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send byof non-identifying attributes.
Review newrelic/helm-charts#2018 first, thanks!!!
Checklist
docsis aligned with the change.CONTRIBUTING.md.log level guidelines.