chore: improve testing server debug shim #1255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1255 +/- ##
=======================================
Coverage 89.21% 89.21%
=======================================
Files 170 170
Lines 7331 7331
Branches 1476 1476
=======================================
Hits 6540 6540
Misses 671 671
Partials 120 120
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logging shim output of the test server alters Ajax and resource payloads when enabled because it generates network requests to capture the log messages. This change introduces a global array that intercepts and stores log messages in it that can be fetched on the fly with a browser execute statement.
Overview
An example of how to use this would be something like:
console.log(await getDebugLogs())This will return the current state of the log message buffer. Anytime something like
console.logis called in the test execution step (client side), the log buffer will be populated with the contents. You must start the test server with the-dflag as before for the shim to be injected into the page.Related Issue(s)
Testing