Skip to content

feat: Capture Page Resource Assets #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 9, 2024
Merged

Conversation

metal-messiah
Copy link
Member

Add detection for page resource assets which captures data as a BrowserPerformance event. This feature is being shipped in an experimental state and is off by default. To opt in to using this feature, it can be turned on by setting the config value init.performance.resources.enabled = true in Copy/Paste or NPM installations.

Overview

See this CDD for the base behavior of this feature.

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-330514

Testing

New unit and e2e tests have been added to validate the behavior.

Copy link

github-actions bot commented Nov 19, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 29.31 kB / 10.64 kB (gzip) 29.39 kB / 10.68 kB (gzip) 0.27% / 0.38% (gzip)
lite async-chunk 54.3 kB / 17.59 kB (gzip) 53.39 kB / 17.35 kB (gzip) -1.68% / -1.36% (gzip)
pro loader 50.42 kB / 17.43 kB (gzip) 50.83 kB / 17.54 kB (gzip) 0.82% / 0.61% (gzip)
pro async-chunk 100.5 kB / 30.62 kB (gzip) 101.43 kB / 30.9 kB (gzip) 0.92% / 0.88% (gzip)
spa loader 57.99 kB / 19.74 kB (gzip) 58.41 kB / 19.86 kB (gzip) 0.71% / 0.58% (gzip)
spa async-chunk 115.22 kB / 34.91 kB (gzip) 116.15 kB / 35.18 kB (gzip) 0.81% / 0.77% (gzip)

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 76.36364% with 13 lines in your changes missing coverage. Please review.

Project coverage is 89.03%. Comparing base (e00a469) to head (f211fd5).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/features/generic_events/aggregate/index.js 75.67% 5 Missing and 4 partials ⚠️
src/features/generic_events/instrument/index.js 83.33% 2 Missing ⚠️
src/features/jserrors/aggregate/index.js 50.00% 1 Missing ⚠️
src/features/jserrors/instrument/index.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1257      +/-   ##
==========================================
- Coverage   89.25%   89.03%   -0.23%     
==========================================
  Files         170      170              
  Lines        7326     7396      +70     
  Branches     1476     1493      +17     
==========================================
+ Hits         6539     6585      +46     
- Misses        667      690      +23     
- Partials      120      121       +1     
Flag Coverage Δ
integration-tests 91.60% <100.00%> (-0.33%) ⬇️
unit-tests 79.60% <45.45%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 19, 2024

Static Badge

Last ran on December 09, 2024 12:46:57 CST
Checking merge of (f211fd5) into main (e00a469)

ptang-nr
ptang-nr previously approved these changes Dec 6, 2024
@metal-messiah metal-messiah merged commit e4c7deb into main Dec 9, 2024
27 of 32 checks passed
@metal-messiah metal-messiah deleted the page-resources-feature branch December 9, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants