feat: added custom segments app #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
reviewed
Jul 17, 2024
bizob2828
requested changes
Jul 17, 2024
There was a problem hiding this comment.
The intent of replacing these examples from node-newrelic is to wrap them in a webframework so you don't have to run in background transaction. The only example that should be running in background transactions is the example to show how to use that api method. This example is showing how to record custom segments
bizob2828
reviewed
Jul 17, 2024
bizob2828
reviewed
Jul 17, 2024
bizob2828
reviewed
Jul 17, 2024
bizob2828
requested changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition aims to move the examples in node-newrelic/examples/api/segments into a single stand-alone application. The application uses the fastify web framework to showcase how segments can be used in a variety of use cases: callback-based, promise-based, asynchronously, and synchronously.