feat: Add distributed tracing example #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
reviewed
Jul 22, 2024
bizob2828
requested changes
Jul 22, 2024
| * attributes include/exclude lists. | ||
| */ | ||
| allow_all_headers: true, | ||
| distributed_tracing: { |
There was a problem hiding this comment.
it doesn't really matter but DT is on by default and has been for several years now
|
Please link this in the parent README |
bizob2828
reviewed
Jul 22, 2024
| }) | ||
|
|
||
| // since BullMQ is not auto instrumented by the newrelic node agent, we have to manually start a transaction | ||
| return newrelic.startBackgroundTransaction('Message queue - consumer', function innerHandler() { |
There was a problem hiding this comment.
so this creates only 1 transaction. you could wrap every consumption in a transaction because right now it's 1. I know in standard messages queues we create 1 transaction for every consumption
There was a problem hiding this comment.
I would wrap it in the job processor, right?
bizob2828
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Release Notes
Added a message queue example to showcase distributed tracing.
Details
Created a message queue using BullMQ and Redis.
Closes #268