Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: instrument example #280

Merged
merged 12 commits into from
Aug 13, 2024
Merged

feat: instrument example #280

merged 12 commits into from
Aug 13, 2024

Conversation

amychisholm03
Copy link
Contributor

This example uses the newrelic.instrument and shim api to instrument a basic module, a rudimentary job queue.

@amychisholm03 amychisholm03 self-assigned this Jul 26, 2024
jsumners-nr
jsumners-nr previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had a chance to clone this and run through it myself, but it looks good to me.

custom-instrumentation/instrument/index.js Outdated Show resolved Hide resolved
jsumners-nr
jsumners-nr previously approved these changes Jul 31, 2024
View reviewed changes
bizob2828
bizob2828 requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs some work to properly pass in a spec to indicate how recording will happen and naming of the segments

custom-instrumentation/instrument/README.md Show resolved Hide resolved
custom-instrumentation/instrument/index.js Outdated Show resolved Hide resolved
custom-instrumentation/instrument/instrumentation.js Outdated Show resolved Hide resolved
custom-instrumentation/instrument/instrumentation.js Outdated Show resolved Hide resolved
@amychisholm03 @jsumners-nr
fix: typo
8148715 
Co-authored-by: James Sumners <[email protected]>
jsumners-nr
jsumners-nr previously approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the instructions in the readme and it all worked out as written. I have a suggestion based on my experience (data wasn't showing up immediately), but otherwise looks great.

Please wait for Bob to finalize his review.

custom-instrumentation/instrument/README.md Outdated Show resolved Hide resolved
@amychisholm03 @jsumners-nr
fix: readme
368750b 
Co-authored-by: James Sumners <[email protected]>
jsumners-nr
jsumners-nr previously approved these changes Aug 6, 2024
View reviewed changes
@bizob2828 bizob2828 merged commit 44dbdbb into newrelic:main Aug 13, 2024
5 checks passed
@amychisholm03 amychisholm03 deleted the instrument-example branch August 13, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bizob2828 bizob2828 bizob2828 approved these changes

@jsumners-nr jsumners-nr jsumners-nr left review comments

Assignees

@amychisholm03 amychisholm03

Labels
None yet
Projects
Node.js Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amychisholm03 @bizob2828 @jsumners-nr