add package react-dom in nextjs/legacy example

[eddie0329]

Proposed Release Notes

• Due to missing package error occured, Add missing package react-dom in nextjs/legacy example

Links

Details

[CLAassistant]

All committers have signed the CLA.

[jsumners-nr]

Thank you for the PR, but I am not seeing any error mentioning "react-dom" when I follow the instructions in the Readme (npm run build && npm start).

Can you provide a minimal reproduction of the error you are encountering?

[eddie0329]

@jsumners-nr Thank you for wonderful lib and reply.
I got same error when running script dev or build and not sure why you got no errors. Assuming "react-dom" installled globally in your environment?

📌 Reproduction 1:

1. yarn dev or npm run dev
2. visit localhost:3000

📌 Reproduction 2:

1. yarn build or npm run build

📌 Error Screenshot:

[eddie0329]

And I think it's wiered why you got no errors. Next.js requires "react-dom" and there is no "react-dom" in package.json.

[jsumners-nr]

Assuming "react-dom" installled globally in your environment?

No. It is a dependency of next:

❯ npm ls react-dom
nextjs-legacy@ /Users/jsumners/Projects/team-repos/newrelic-node-examples/nextjs-legacy
└─┬ [email protected]
  └── [email protected]

Running npm install should result in the correct dependencies being installed. Please remove the node_modules directory and run npm install.

[eddie0329]

Thank you for reply. It is weired that when i run this project with npm it works. However, when i run it with yarn it requires react-dom.

My yarn version: 1.22.19

How about mention at readme.md that npm package manager is suggested to use?

[jsumners-nr]

I would be okay with a step added between steps 2 and 3 that is "Install dependencies: npm install". Would you like to submit a PR for that?

[eddie0329]

Yeap. I will close this pr and make new one.