Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add security scan with trivy #985

Merged
merged 6 commits into from
Dec 5, 2024
Merged

ci: add security scan with trivy #985

merged 6 commits into from
Dec 5, 2024

Conversation

lavarou
Copy link
Member

@lavarou lavarou commented Nov 14, 2024

Security scan with trivy will be run on push to main and dev, pull request, and daily. trivy will skip scanning vendor subdirectory because the agent is not using code from that directory.

@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Nov 14, 2024

Test Suite Status Result
Multiverse 6/7 passing
SOAK 62/62 passing

@lavarou lavarou force-pushed the ci/add-security-scan branch from 5f42176 to 8b9aa46 Compare November 14, 2024 16:57
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.68%. Comparing base (bae6375) to head (ed68ea5).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #985   +/-   ##
=======================================
  Coverage   78.68%   78.68%           
=======================================
  Files         196      196           
  Lines       27047    27047           
=======================================
  Hits        21281    21281           
  Misses       5766     5766           
Flag Coverage Δ
agent-for-php-7.2 78.69% <ø> (ø)
agent-for-php-7.3 78.71% <ø> (ø)
agent-for-php-7.4 78.41% <ø> (ø)
agent-for-php-8.0 78.43% <ø> (ø)
agent-for-php-8.1 78.42% <ø> (ø)
agent-for-php-8.2 78.01% <ø> (ø)
agent-for-php-8.3 78.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lavarou lavarou force-pushed the ci/add-security-scan branch 3 times, most recently from 4cb8d62 to cab9c27 Compare November 15, 2024 01:17
@lavarou lavarou self-assigned this Nov 15, 2024
@lavarou lavarou force-pushed the ci/add-security-scan branch from cab9c27 to eccaf64 Compare November 20, 2024 14:39
bduranleau-nr
bduranleau-nr previously approved these changes Nov 20, 2024
Security scan with trivy will be run on push to main and dev, pull request,
and daily. trivy will skip scanning vendor subdirectory because the agent
is not using code from that directory.
Storing trivy scan configuration in a file will ensure the same configuration
is used regardless if trivy is run as GitHub action or when trivy is used
locally.
Use mirror.gcr.io as source registry for trivy-db in attempt to avoid
`TOOMANYREQUESTS` error when downloading it from default registry (ghcr.io).
Ignore AVD-DS-0026 (missing HEALTHCHECK in Dockerfile) reported in
`files/Dockerfile`, which is used to build `devenv` service container
image. `devenv` service container is used to run an interactive shell
and having `HEALTHCHECK` in such a service doesn't make sense.
Remove dead code and address AVD-DS-0002
@lavarou lavarou merged commit 9997966 into dev Dec 5, 2024
57 checks passed
@lavarou lavarou deleted the ci/add-security-scan branch December 5, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants