Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attrs for aws lambda entity #1227

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

hmstepanek
Copy link
Contributor

@hmstepanek hmstepanek commented Oct 7, 2024

Overview

Add attrs for aws lambda entity linking.

When an application invokes a Lambda, linking between the application and AWS Lambdas is done using the following span attributes:

cloud.platform: the string aws_lambda
cloud.resource_id: the ARN for the Lambda, or an alias or version, if it can be determined.
Lambda ARNs follow the format:

arn:${Partition}:lambda:${Region}:${Account}:function:${FunctionName}
arn:${Partition}:lambda:${Region}:${Account}:function:${FunctionName}:${Alias}
arn:${Partition}:lambda:${Region}:${Account}:function:${FunctionName}:${Version}

Copy link

github-actions bot commented Oct 7, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 2 0 5.06s
✅ PYTHON black 3 0 0 1.1s
✅ PYTHON flake8 3 0 0.62s
✅ PYTHON isort 3 0 0 0.21s
✅ PYTHON pylint 3 0 6.2s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@mergify mergify bot added the tests-failing label Oct 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.23%. Comparing base (96fa0e0) to head (9033706).

Files with missing lines Patch % Lines
newrelic/hooks/external_botocore.py 82.35% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1227      +/-   ##
==========================================
- Coverage   81.35%   81.23%   -0.12%     
==========================================
  Files         198      198              
  Lines       21675    21692      +17     
  Branches     3434     3434              
==========================================
- Hits        17633    17622      -11     
- Misses       2913     2937      +24     
- Partials     1129     1133       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants