Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package capture harvest #1228

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Package capture harvest #1228

wants to merge 8 commits into from

Conversation

lrafeei
Copy link
Contributor

@lrafeei lrafeei commented Oct 8, 2024

This PR aims to alleviate some of the time consumed by package data collection in the connect cycle. Instead of collecting all modules used in the application at startup, the agent uses the fast harvest cycle to incrementally collect this data and sends it though the update_loaded_modules endpoint instead of the connect endpoint (through the "environment" key).

Note: despite the term "Jars" not being used by Python to refer to packages/modules, this is the exact string the endpoint needs in order to process the data.

Copy link

github-actions bot commented Oct 8, 2024

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
❌ PYTHON bandit 3 1 5.3s
✅ PYTHON black 5 1 0 2.18s
✅ PYTHON flake8 5 0 0.69s
✅ PYTHON isort 5 1 0 0.29s
✅ PYTHON pylint 5 0 4.7s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.43%. Comparing base (3a001b0) to head (a5faab6).

Files with missing lines Patch % Lines
newrelic/core/application.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1228      +/-   ##
==========================================
- Coverage   81.23%   71.43%   -9.80%     
==========================================
  Files         197      197              
  Lines       21643    21662      +19     
  Branches     3782     3784       +2     
==========================================
- Hits        17581    15474    -2107     
- Misses       2919     5032    +2113     
- Partials     1143     1156      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot added the tests-failing label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants