Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS entity agent attributes to DynamoDB spans #1252

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hmstepanek
Copy link
Contributor

@hmstepanek hmstepanek commented Nov 13, 2024

Overview

Add AWS entity agent attributes to DynamoDB spans. See implementation_guides/aws-sdk.md in agent specs for details.
Note this is dependent on #1249.

@hmstepanek hmstepanek requested a review from a team as a code owner November 13, 2024 00:50
Copy link

github-actions bot commented Nov 13, 2024

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 4 0 6.5s
✅ PYTHON black 6 1 0 2.5s
❌ PYTHON flake8 6 1 1.55s
✅ PYTHON isort 6 1 0 0.39s
✅ PYTHON pylint 6 0 10.55s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 54.65116% with 39 lines in your changes missing coverage. Please review.

Project coverage is 81.15%. Comparing base (6b8fb08) to head (ada6b0f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
newrelic/hooks/external_botocore.py 44.11% 24 Missing and 14 partials ⚠️
newrelic/config.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1252      +/-   ##
==========================================
- Coverage   81.27%   81.15%   -0.12%     
==========================================
  Files         200      200              
  Lines       21953    22038      +85     
  Branches     3479     3502      +23     
==========================================
+ Hits        17842    17885      +43     
- Misses       2965     2989      +24     
- Partials     1146     1164      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

newrelic/hooks/external_botocore.py Dismissed Show dismissed Hide dismissed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants