Skip to content

Commit

Permalink
fix: grpc
Browse files Browse the repository at this point in the history
  • Loading branch information
amychisholm03 committed Sep 10, 2024
1 parent 5783390 commit 43340b3
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 7 deletions.
2 changes: 1 addition & 1 deletion test/versioned/grpc/server-bidi-streaming.tap.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ tap.test('gRPC Server: Bidi Streaming', (t) => {

t.ok(transaction, 'transaction exists')
assertServerTransaction({ t, transaction, fnName: 'SayHelloBidiStream' })
assertServerMetrics({ t, agentMetrics: agent.metrics._metrics, fnName: 'SayHelloBidiStream' })
assertServerMetrics({ agentMetrics: agent.metrics._metrics, fnName: 'SayHelloBidiStream' })
t.end()
})

Expand Down
4 changes: 1 addition & 3 deletions test/versioned/grpc/server-client-streaming.tap.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ tap.test('gRPC Server: Client Streaming', (t) => {
'response message is correct'
)
assertServerTransaction({ t, transaction, fnName: 'SayHelloClientStream' })
assertServerMetrics({ t, agentMetrics: agent.metrics._metrics, fnName: 'SayHelloClientStream' })
assertServerMetrics({ agentMetrics: agent.metrics._metrics, fnName: 'SayHelloClientStream' })
})

t.test('should add DT headers when `distributed_tracing` is enabled', async (t) => {
Expand Down Expand Up @@ -200,7 +200,6 @@ tap.test('gRPC Server: Client Streaming', (t) => {
expectedStatusCode: ERR_CODE
})
assertServerMetrics({
t,
agentMetrics: agent.metrics._metrics,
fnName: 'SayErrorClientStream',
expectedStatusCode: ERR_CODE
Expand Down Expand Up @@ -240,7 +239,6 @@ tap.test('gRPC Server: Client Streaming', (t) => {
expectedStatusCode: HALT_CODE
})
assertServerMetrics({
t,
agentMetrics: agent.metrics._metrics,
fnName: 'SayErrorClientStream',
expectedStatusCode: HALT_CODE
Expand Down
2 changes: 1 addition & 1 deletion test/versioned/grpc/server-streaming.tap.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ tap.test('gRPC Server: Server Streaming', (t) => {
})
t.ok(transaction, 'transaction exists')
assertServerTransaction({ t, transaction, fnName: 'SayHelloServerStream' })
assertServerMetrics({ t, agentMetrics: agent.metrics._metrics, fnName: 'SayHelloServerStream' })
assertServerMetrics({ agentMetrics: agent.metrics._metrics, fnName: 'SayHelloServerStream' })
t.end()
})

Expand Down
2 changes: 1 addition & 1 deletion test/versioned/grpc/server-unary.tap.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ tap.test('gRPC Server: Unary Requests', (t) => {
t.equal(response.message, 'Hello New Relic', 'response message is correct')
t.ok(transaction, 'transaction exists')
assertServerTransaction({ t, transaction, fnName: 'SayHello' })
assertServerMetrics({ t, agentMetrics: agent.metrics._metrics, fnName: 'SayHello' })
assertServerMetrics({ agentMetrics: agent.metrics._metrics, fnName: 'SayHello' })
t.end()
})

Expand Down
2 changes: 1 addition & 1 deletion test/versioned/grpc/util.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ util.assertServerTransaction = function assertServerTransaction({
t.equal(attributes['request.uri'], expectedUri, `should have server uri ${expectedUri}`)
}

util.assertServerMetrics = function assertServerMetrics({ t, agentMetrics, fnName }) {
util.assertServerMetrics = function assertServerMetrics({ agentMetrics, fnName }) {
const expectedServerMetrics = [
[{ name: 'WebTransaction' }],
[{ name: 'WebTransactionTotalTime' }],
Expand Down

0 comments on commit 43340b3

Please sign in to comment.