Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tx from segment #2646

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Remove tx from segment #2646

wants to merge 9 commits into from

Conversation

bizob2828
Copy link
Member

Description

Please provide a brief description of the changes introduced in this pull request.
What problem does it solve? What is the context of this change?

How to Test

Please describe how you have tested these changes. Have you run the code against an example application?
What steps did you take to ensure that the changes are working correctly?

Related Issues

Please include any related issues or pull requests in this section, using the format Closes #<issue number> or Fixes #<issue number> if applicable.

Copy link
Contributor

Thank you for your contribution! We require all PR titles to follow the Conventional Commits specification.
Please update your PR title with the appropriate type and we'll try again!

No release type found in pull request title "Remove tx from segment". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - build
 - chore
 - ci
 - docs
 - feat
 - fix
 - perf
 - refactor
 - revert
 - security
 - style
 - test

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 98.96755% with 7 lines in your changes missing coverage. Please review.

Project coverage is 97.23%. Comparing base (b917b3e) to head (94f381a).

Files with missing lines Patch % Lines
lib/util/probe.js 74.07% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2646      +/-   ##
==========================================
+ Coverage   97.21%   97.23%   +0.01%     
==========================================
  Files         291      293       +2     
  Lines       45928    46248     +320     
==========================================
+ Hits        44650    44967     +317     
- Misses       1278     1281       +3     
Flag Coverage Δ
integration-tests-cjs-18.x 74.13% <65.28%> (-0.05%) ⬇️
integration-tests-cjs-20.x 74.13% <65.28%> (-0.05%) ⬇️
integration-tests-cjs-22.x 74.17% <65.28%> (-0.05%) ⬇️
integration-tests-esm-18.x 49.59% <23.43%> (-0.12%) ⬇️
integration-tests-esm-20.x 49.60% <23.43%> (-0.12%) ⬇️
integration-tests-esm-22.x 49.62% <23.43%> (-0.12%) ⬇️
unit-tests-18.x 88.79% <78.12%> (?)
unit-tests-20.x 88.79% <78.12%> (-0.08%) ⬇️
unit-tests-22.x 88.79% <78.12%> (-0.08%) ⬇️
versioned-tests-18.x 79.08% <92.60%> (-0.03%) ⬇️
versioned-tests-20.x 79.06% <92.60%> (-0.05%) ⬇️
versioned-tests-22.x 79.10% <92.60%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs PR Review
Development

Successfully merging this pull request may close these issues.

2 participants