refactor: Updated @langchain/core instrumentation to subscribe to events emitted
#3493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amychisholm03
changed the title
@langchain/core instrumentation to subscribe to events emitted
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3493 +/- ##
==========================================
- Coverage 97.81% 89.52% -8.29%
==========================================
Files 434 435 +1
Lines 56941 57091 +150
Branches 1 1
==========================================
- Hits 55698 51112 -4586
- Misses 1243 5979 +4736
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amychisholm03
force-pushed
the
NR-3442/langchain-subscriber
branch
from
51a3401 to
f44078a
Compare
amychisholm03
force-pushed
the
NR-3442/langchain-subscriber
branch
from
9f9d6b0 to
7c0304a
Compare
amychisholm03
force-pushed
the
NR-3442/langchain-subscriber
branch
2 times, most recently
from
427f4c0 to
a050bbb
Compare
bizob2828
requested changes
Nov 12, 2025
Member
bizob2828
left a comment
bizob2828
left a comment
There was a problem hiding this comment.
Same as google gen ai. we need to look at the spec for enabling/disabling AI monitoring, not sure if we have this correct
amychisholm03
force-pushed
the
NR-3442/langchain-subscriber
branch
from
a050bbb to
4f874a9
Compare
bizob2828
requested changes
Dec 5, 2025
Member
bizob2828
left a comment
bizob2828
left a comment
There was a problem hiding this comment.
I'm going to have a lot of the same comments:
- remove optional chaining for checking configuration
- use
this.enabledto check if ai monitoring is enabled - add a
this.streamingEnabledand use that to check if streaming is enabled - We should only be checking if ai monitoring is enabled before creating LLM events, the segment should still be created
amychisholm03
force-pushed
the
NR-3442/langchain-subscriber
branch
3 times, most recently
from
a51660c to
9fbf2c0
Compare
bizob2828
requested changes
Dec 9, 2025
| if (!this.streamingEnabled) { | ||
| logger.warn('`ai_monitoring.streaming.enabled` is set to `false`, stream will not be instrumented.') | ||
| agent.metrics.getOrCreateMetric(STREAMING_DISABLED).incrementCallCount() | ||
| agent.metrics |
Member
There was a problem hiding this comment.
this is fine but all the other AIM instrumentations wraps this in an addLlmMeta, that can happen in #3487
amychisholm03
force-pushed
the
NR-3442/langchain-subscriber
branch
from
cb5d298 to
c620c39
Compare
amychisholm03
force-pushed
the
NR-3442/langchain-subscriber
branch
from
d2a7fd7 to
964d537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #3442.