-
Notifications
You must be signed in to change notification settings - Fork 421
feat: Added support for @langchain/aws
#3563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added support for @langchain/aws
#3563
Conversation
ec06c49 to
a37f420
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3563 +/- ##
===========================================
+ Coverage 81.30% 97.68% +16.38%
===========================================
Files 420 434 +14
Lines 55460 56838 +1378
Branches 1 1
===========================================
+ Hits 45090 55524 +10434
+ Misses 10370 1314 -9056
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bizob2828
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't reviewed it all but this approach needs updated
81e9ed3 to
7e5ff78
Compare
bizob2828
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests are still failing for me:
stderr
node:fs:560
return binding.open(
^
Error: ENOENT: no such file or directory, open '../../langchain/node_modules/@aws-sdk/client-bedrock-runtime/package.json'
at Object.openSync (node:fs:560:18)
at Object.readFileSync (node:fs:444:35)
at getAiResponseServer (/Users/revans/code/release/node-newrelic/test/versioned/aws-sdk-v3/common.js:206:8)
at Object.<anonymous> (/Users/revans/code/release/node-newrelic/test/versioned/langchain/bedrock/runnables.test.js:30:32)
at Module._compile (node:internal/modules/cjs/loader:1760:14)
at Object..js (node:internal/modules/cjs/loader:1893:10)
at Module.load (node:internal/modules/cjs/loader:1480:32)
at Module._load (node:internal/modules/cjs/loader:1299:12)
at TracingChannel.traceSync (node:diagnostics_channel:328:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:244:24) {
errno: -2,
code: 'ENOENT',
syscall: 'open',
path: '../../langchain/node_modules/@aws-sdk/client-bedrock-runtime/package.json'
}you cannot pass in
c3600b2 to
5083f1f
Compare
@langchain/aws bedrock tests@langchain/aws
bizob2828
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5083f1f to
0cbe0f3
Compare
ea960b4 to
313aadc
Compare
@langchain/aws @langchain/aws
33e1e54 to
5bff6f2
Compare
6601654 to
f7ac5dc
Compare
bizob2828
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very close. the 2 runnables tests needs to templatize the prompt and pass in valid template when calling invoke or stream. also a todo is still there with invalid assertion description
bizob2828
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work on getting these tests in here and fixing our instrumentation to handle findings
Description
Adds tests for the
@langchain/awspackage, specifically testing the classes related to AWS Bedrock:ChatBedrockConverseandBedrockEmbeddings.Fixes a bug where we were not properly handing AWS Bedrock streams when it was piped from another source and where the stream chunk type may differ.
How to Test
Related Issues
Closes #3489