feat: Added partial granularity tracking metrics #3566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svetlanabrennan
changed the title
bizob2828
requested changes
Dec 5, 2025
Member
bizob2828
left a comment
bizob2828
left a comment
There was a problem hiding this comment.
These metrics should only be incremented if the trace is partial
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3566 +/- ##
===========================================
+ Coverage 81.27% 97.68% +16.40%
===========================================
Files 417 428 +11
Lines 55275 56605 +1330
Branches 1 1
===========================================
+ Hits 44927 55293 +10366
+ Misses 10348 1312 -9036
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bizob2828
requested changes
Dec 8, 2025
| const helper = require('#testlib/agent_helper.js') | ||
| const SpanEvent = require('#agentlib/spans/span-event.js') | ||
|
|
||
| test('Partial Granularity metrics with Full Granularity settings', async (t) => { |
Member
There was a problem hiding this comment.
full granularity tests are in span-events.test.js, we don't need another file for this
Contributor
Author
There was a problem hiding this comment.
Got it. I'll move them. Sorry about that.
bizob2828
approved these changes
Dec 8, 2025
github-project-automation
bot
moved this from Needs PR Review
to Done: Issues recently completed
in Node.js Engineering Board
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to add
Supportability/DistributedTrace/PartialGranularity/<partial granularity type>/Span/Instrumentedmetric which represents the total number of span events that were instrumented and would have been recorded (if the trace was full granularity) before partial granularity dropped them.And we need to add
Supportability/DistributedTrace/PartialGranularity/<partial granularity type>/Span/Keptmetric that represents the total number of span events that were recorded and kept by partial granularity (aka that were not dropped).How to Test
Run
npm run testRelated Issues
Partially closes #3453 (we still need to add compact metrics in a separate PR at a future date).