[ci/cd] Refactor e2e pipeline #459
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kang-makes
force-pushed
the
feature/e2e-kubernetes-1-24
branch
24 times, most recently
from
1e5f256
to
a001ebd
Compare
kang-makes
force-pushed
the
feature/e2e-kubernetes-1-24
branch
from
a001ebd
to
dc97fa2
Compare
|
There is a missing metrics that got deprecated in 1.21 that is missing in 1.23 and is breaking these tests: Fixing integration tests should fix this issue #460 |
roobre
suggested changes
May 29, 2022
Comment on lines
+61
to
+62
| cri: | ||
| - containerd |
There was a problem hiding this comment.
I'm not happy about stopping to test with docker. It might be a mess to check which of the versions actually support docker, so perhaps for now we could just hardcode it here?
| - ${{ needs.generate-kubernetes-versions.outputs.previous_1 }} | ||
| - ${{ needs.generate-kubernetes-versions.outputs.previous_2 }} | ||
| - ${{ needs.generate-kubernetes-versions.outputs.previous_3 }} | ||
| - ${{ needs.generate-kubernetes-versions.outputs.previous_4 }} |
There was a problem hiding this comment.
I'd add, even if hardcoded, the earliest version we support to ensure we do not break anything for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dynamically generates the matrix for the Kubernetes clusters to test while allowing to set the latest version supported instead of using the latest stable.
Fix #438
Fix #438Minikube still does not support 1.24