Skip to content

Conversation

@Aashirwadjain
Copy link
Contributor

@Aashirwadjain Aashirwadjain commented Oct 6, 2025

Description

This PR aims to add support for thresholds_with_series_overrides in newrelic_one_dashboard.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 20.10050% with 318 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.25%. Comparing base (839155d) to head (c05c4f9).

Files with missing lines Patch % Lines
newrelic/structures_newrelic_one_dashboard.go 0.00% 317 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2947      +/-   ##
==========================================
- Coverage   30.38%   30.25%   -0.14%     
==========================================
  Files         107      107              
  Lines       29651    30045     +394     
==========================================
+ Hits         9009     9089      +80     
- Misses      20460    20773     +313     
- Partials      182      183       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Aashirwadjain Aashirwadjain force-pushed the add-thresholds-series-overrides-support branch from 86c3f60 to df5bc27 Compare October 6, 2025 13:23
@Aashirwadjain Aashirwadjain force-pushed the add-thresholds-series-overrides-support branch from 7b2259f to e60a893 Compare October 8, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants