Skip to content

Conversation

@msivant
Copy link
Collaborator

@msivant msivant commented Nov 19, 2025

Description

Implement terraform module for WIF onboarding.
JIRA LINK: https://new-relic.atlassian.net/browse/NR-489616

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

Creation:
image

Deletion:
image

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.66%. Comparing base (b75a551) to head (b317c76).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2971   +/-   ##
=======================================
  Coverage   34.66%   34.66%           
=======================================
  Files         107      107           
  Lines       23759    23759           
=======================================
  Hits         8237     8237           
  Misses      15335    15335           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@msivant msivant marked this pull request as ready for review November 24, 2025 03:39
Copy link

@amol-asthana amol-asthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

❌ Invalid Conventional Commits Detected

The following commits do not follow the Conventional Commits format:

f3eb5fb - Merge branch 'main' into sm/NR-489616

Please update these commit messages to follow the format:
<type>[optional scope]: <description>

Valid types: build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

❌ Invalid Conventional Commits Detected

The following commits do not follow the Conventional Commits format:

f3eb5fb - Merge branch 'main' into sm/NR-489616

Please update these commit messages to follow the format:
<type>[optional scope]: <description>

Valid types: build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test

Copy link

@amol-asthana amol-asthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

❌ Invalid Conventional Commits Detected

The following commits do not follow the Conventional Commits format:

f3eb5fb - Merge branch 'main' into sm/NR-489616

Please update these commit messages to follow the format:
<type>[optional scope]: <description>

Valid types: build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test

@pranav-new-relic
Copy link
Member

Thanks for the screenshots @msivant - merging this as this appears to have been tested 👍

@pranav-new-relic pranav-new-relic merged commit 8b2f299 into main Dec 4, 2025
16 checks passed
@pranav-new-relic pranav-new-relic deleted the sm/NR-489616 branch December 4, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants