Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for VEX #72

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support for VEX #72

wants to merge 2 commits into from

Conversation

ziadhany
Copy link

@ziadhany ziadhany commented Apr 9, 2024

image
Screenshot from 2024-04-29 20-46-55
Screenshot from 2024-05-04 23-16-35

@ziadhany ziadhany marked this pull request as ready for review April 29, 2024 20:56
@ziadhany
Copy link
Author

@tdruez @DennisClark I'm finalizing the VCIO to CycloneDX vulnerability mapping (references, ratings, packages). If you have any feedback, please let me know.

@DennisClark
Copy link
Member

@ziadhany the screen shots look nice. Do you have an example of the VEX document that you can attach for me to review? Thanks.

@DennisClark
Copy link
Member

@ziadhany Please see if you can support CycloneDX spec 1.4, 1.5, and 1.6 for the VEX.

@ziadhany
Copy link
Author

@ziadhany the screen shots look nice. Do you have an example of the VEX document that you can attach for me to review? Thanks.

dejacode_nexB_product_vex(7).json

Fix Vex export test
Remove get_export_vex_url func from Package model
Add support for vulnerability encoder
Add a test for get_references_and_rating
Rename UI VEX fields
Fix Export VEX View
Rename VEX model
Add VEX Form
Fix UI bug and add the model to dataspace
Add basic VEX mapping for CycloneDX
Automate VEX creation
Add the basic Vex Form
Add the skeleton view and form for vex
Add Product VEX List view and update tab_vex
Add the basic for vex model
Add the basic skeleton for vex export

Signed-off-by: ziadhany <[email protected]>
versions.append(BomTargetVersionRange(version=vul_purl.version, status=status))

if versions:
bom_target = BomTarget(ref="urn:cdx:serialNumber/version#bom-ref", versions=versions)
Copy link
Author

@ziadhany ziadhany May 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused about bom_target
especially this part urn:cdx:3e671687-395b-41f5-a30f-a58921a69b79/1#
where can we get bom ref? ( vulnerablecode doesn't provide the bom ref ) should we create a bom and pass the bom ref to vex

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ziadhany thanks for asking, yes. We should also create a CycloneDX SBOM at the same specification level as the VEX and pass the bom ref to the VEX.

@DennisClark
Copy link
Member

@ziadhany as we agreed in our VCIO meeting, please use the Package URL (PURL) as the bom_ref. thanks.

Add package purl string as a bom ref

Signed-off-by: ziadhany <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants