🚀 1단계 - 리팩터링(상품)

README.md

@@ -199,3 +199,13 @@ docker compose -p kitchenpos up -d
 - `Order`는 접수 대기 ➜ 접수 ➜ 서빙 ➜ 계산 완료 순서로 진행된다.
 - `OrderLineItem`는 가격과 수량을 가진다.
 - `OrderLineItem`의 수량은 1보다 커야 한다.
+
+
+#### step1 요구사항
+
+- 키친포스의 요구 사항과 용어 사전, 모델링을 기반으로 상품 CONTEXT를 리팩터링한다.
+- 상품 CONTEXT의 도메인 계층만 먼저 구현한다.
+- products 패키지 밑에 tobe.domain 패키지를 만들고 거기서부터 구현을 시작한다.
+- 용어 사전과 모델링이 부자연스럽거나 불완전하거나 잘못된 경우 지속적으로 수정한다.
+- 새로운 모델에 맞게끔 클래스, 메서드, 모듈의 이름을 다시 지으면서 코드를 리팩터링한다.
+- REPOSITORY 구현 시 자신에게 익숙하고 편한 것을 선택하여 진행한다.

build.gradle.kts

@@ -13,7 +13,7 @@ group = "camp.nextstep.edu"
 version = "0.0.1-SNAPSHOT"
 
 java {
-    sourceCompatibility = JavaVersion.VERSION_21
+    sourceCompatibility = JavaVersion.VERSION_17
 }
 
 repositories {

src/main/java/kitchenpos/menus/application/MenuService.java

@@ -5,9 +5,9 @@
 import kitchenpos.menus.domain.MenuGroupRepository;
 import kitchenpos.menus.domain.MenuProduct;
 import kitchenpos.menus.domain.MenuRepository;
-import kitchenpos.products.domain.Product;
-import kitchenpos.products.domain.ProductRepository;
-import kitchenpos.products.infra.PurgomalumClient;
+import kitchenpos.products.asis.domain.Product;
+import kitchenpos.products.asis.domain.ProductRepository;
+import kitchenpos.products.asis.infra.PurgomalumClient;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 

src/main/java/kitchenpos/menus/domain/MenuProduct.java

@@ -10,7 +10,7 @@
 import jakarta.persistence.ManyToOne;
 import jakarta.persistence.Table;
 import jakarta.persistence.Transient;
-import kitchenpos.products.domain.Product;
+import kitchenpos.products.asis.domain.Product;
 
 import java.util.UUID;
 

src/main/java/kitchenpos/products/application/ProductService.java → src/main/java/kitchenpos/products/asis/application/ProductService.java

@@ -1,11 +1,11 @@
-package kitchenpos.products.application;
+package kitchenpos.products.asis.application;
 
 import kitchenpos.menus.domain.Menu;
 import kitchenpos.menus.domain.MenuProduct;
 import kitchenpos.menus.domain.MenuRepository;
-import kitchenpos.products.domain.Product;
-import kitchenpos.products.domain.ProductRepository;
-import kitchenpos.products.infra.PurgomalumClient;
+import kitchenpos.products.asis.domain.Product;
+import kitchenpos.products.asis.domain.ProductRepository;
+import kitchenpos.products.asis.infra.PurgomalumClient;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 

src/main/java/kitchenpos/products/domain/JpaProductRepository.java → src/main/java/kitchenpos/products/asis/domain/JpaProductRepository.java

@@ -1,4 +1,4 @@
-package kitchenpos.products.domain;
+package kitchenpos.products.asis.domain;
 
 import org.springframework.data.jpa.repository.JpaRepository;
 

src/main/java/kitchenpos/products/domain/Product.java → src/main/java/kitchenpos/products/asis/domain/Product.java

@@ -1,4 +1,4 @@
-package kitchenpos.products.domain;
+package kitchenpos.products.asis.domain;
 
 import jakarta.persistence.Column;
 import jakarta.persistence.Entity;

src/main/java/kitchenpos/products/domain/ProductRepository.java → src/main/java/kitchenpos/products/asis/domain/ProductRepository.java

@@ -1,4 +1,4 @@
-package kitchenpos.products.domain;
+package kitchenpos.products.asis.domain;
 
 import java.util.List;
 import java.util.Optional;

src/main/java/kitchenpos/products/infra/DefaultPurgomalumClient.java → src/main/java/kitchenpos/products/asis/infra/DefaultPurgomalumClient.java

@@ -1,4 +1,4 @@
-package kitchenpos.products.infra;
+package kitchenpos.products.asis.infra;
 
 import org.springframework.boot.web.client.RestTemplateBuilder;
 import org.springframework.stereotype.Component;

src/main/java/kitchenpos/products/infra/PurgomalumClient.java → src/main/java/kitchenpos/products/asis/infra/PurgomalumClient.java

@@ -1,4 +1,4 @@
-package kitchenpos.products.infra;
+package kitchenpos.products.asis.infra;
 
 public interface PurgomalumClient {
     boolean containsProfanity(String text);

src/main/java/kitchenpos/products/tobe/application/ProductService.java

@@ -0,0 +1,74 @@
+package kitchenpos.products.tobe.application;
+
+import java.math.BigDecimal;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.UUID;
+import kitchenpos.menus.domain.Menu;
+import kitchenpos.menus.domain.MenuProduct;
+import kitchenpos.menus.domain.MenuRepository;
+import kitchenpos.products.tobe.application.dto.ProductCreateRequest;
+import kitchenpos.products.tobe.application.dto.ProductPriceUpdateRequest;
+import kitchenpos.products.tobe.application.dto.ProductResponse;
+import kitchenpos.products.tobe.domain.Product;
+import kitchenpos.products.tobe.domain.ProductRepository;
+import kitchenpos.products.tobe.infra.PurgomalumClient;
+import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
+
+@Service
+public class ProductService {
+
+    private final ProductRepository jpaProductRepository;
+    private final MenuRepository menuRepository;
+    private final PurgomalumClient purgomalumClient;
+
+    public ProductService(
+        final ProductRepository productRepository,
+        final MenuRepository menuRepository,
+        final PurgomalumClient purgomalumClient
+                         ) {
+        this.jpaProductRepository = productRepository;
+        this.menuRepository = menuRepository;
+        this.purgomalumClient = purgomalumClient;
+    }
+
+    @Transactional
+    public ProductResponse create(ProductCreateRequest request) {
+        Product product = jpaProductRepository.save(Product.of(request.getName(), request.getPrice(), purgomalumClient));
+
+        return ProductResponse.toResponse(product);
+    }
+
+    @Transactional
+    public ProductResponse changePrice(UUID productId, ProductPriceUpdateRequest request) {
+
+        Product product = jpaProductRepository.findById(productId)
+                                              .orElseThrow(NoSuchElementException::new);
+        product.updatePrice(request.getPrice());
+
+        final List<Menu> menus = menuRepository.findAllByProductId(productId);
+        for (final Menu menu : menus) {
+            BigDecimal sum = BigDecimal.ZERO;
+            for (final MenuProduct menuProduct : menu.getMenuProducts()) {
+                sum = sum.add(
+                    menuProduct.getProduct()
+                               .getPrice()
+                               .multiply(BigDecimal.valueOf(menuProduct.getQuantity()))
+                             );
+            }
+            if (menu.getPrice().compareTo(sum) > 0) {
+                menu.setDisplayed(false);
+            }
+        }
+        return ProductResponse.toResponse(product);
+    }
+
+    @Transactional(readOnly = true)
+    public List<ProductResponse> findAll() {
+        return jpaProductRepository.findAll()
+                            .stream()
+            .map(ProductResponse::toResponse)
+            .toList();
+    }
+}

src/main/java/kitchenpos/products/tobe/application/dto/ProductCreateRequest.java

@@ -0,0 +1,21 @@
+package kitchenpos.products.tobe.application.dto;
+
+import java.math.BigDecimal;
+
+public class ProductCreateRequest {
+    private final String name;
+    private final BigDecimal price;
+
+    public ProductCreateRequest(String name, BigDecimal price) {
+        this.name = name;
+        this.price = price;
+    }
+
+    public String getName() {
+        return name;
+    }
+
+    public BigDecimal getPrice() {
+        return price;
+    }
+}

src/main/java/kitchenpos/products/tobe/application/dto/ProductPriceUpdateRequest.java

@@ -0,0 +1,15 @@
+package kitchenpos.products.tobe.application.dto;
+
+import java.math.BigDecimal;
+
+public class ProductPriceUpdateRequest {
+    private final BigDecimal price;
+
+    public ProductPriceUpdateRequest(BigDecimal price) {
+        this.price = price;
+    }
+
+    public BigDecimal getPrice() {
+        return price;
+    }
+}

src/main/java/kitchenpos/products/tobe/application/dto/ProductResponse.java

@@ -0,0 +1,33 @@
+package kitchenpos.products.tobe.application.dto;
+
+import java.math.BigDecimal;
+import java.util.UUID;
+import kitchenpos.products.tobe.domain.Product;
+
+public class ProductResponse {
+    private final UUID id;
+    private final String name;
+    private final BigDecimal price;
+
+    public ProductResponse(UUID id, String name, BigDecimal price) {
+        this.id = id;
+        this.name = name;
+        this.price = price;
+    }
+
+    public UUID getId() {
+        return id;
+    }
+
+    public String getName() {
+        return name;
+    }
+
+    public BigDecimal getPrice() {
+        return price;
+    }
+
+    public static ProductResponse toResponse(Product product) {
+        return new ProductResponse(product.getId(), product.getName(), product.getPrice());
+    }
+}

src/main/java/kitchenpos/products/tobe/domain/Product.java

@@ -0,0 +1,56 @@
+package kitchenpos.products.tobe.domain;
+
+import jakarta.persistence.Column;
+import jakarta.persistence.Embedded;
+import jakarta.persistence.Entity;
+import jakarta.persistence.Id;
+import jakarta.persistence.Table;
+
+import java.math.BigDecimal;
+import java.util.UUID;
+import kitchenpos.products.tobe.infra.PurgomalumClient;
+
+@Table(name = "product")
+@Entity
+public class Product {
+
+    @Column(name = "id", columnDefinition = "binary(16)")
+    @Id
+    private UUID id;
+
+    @Embedded
+    private ProductName name;
+
+    @Embedded
+    private ProductPrice price;
+
+    protected Product() {
+    }
+
+    private Product(ProductName name, ProductPrice price) {
+        this.id = UUID.randomUUID();
+        this.name = name;
+        this.price = price;
+    }
+
+    public static Product of(String name, BigDecimal price, PurgomalumClient purgomalumClient) {
+        return new Product(ProductName.from(name, purgomalumClient),
+                           ProductPrice.from(price));
+    }
+
+    public UUID getId() {
+        return id;
+    }
+
+    public String getName() {
+        return name.getName();
+    }
+
+    public BigDecimal getPrice() {
+        return price.getPrice();
+    }
+
+    public void updatePrice(BigDecimal price) {
+        this.price = ProductPrice.from(price);
+    }
+}

src/main/java/kitchenpos/products/tobe/domain/ProductName.java

@@ -0,0 +1,34 @@
+package kitchenpos.products.tobe.domain;
+
+import jakarta.persistence.Column;
+import jakarta.persistence.Embeddable;
+import kitchenpos.products.tobe.infra.PurgomalumClient;
+
+@Embeddable
+public class ProductName {
+
+    @Column(name = "name", nullable = false)
+    private String name;
+
+    protected ProductName() {
+    }
+
+    private ProductName(String name) {
+        this.name = name;
+    }
+
+    public static ProductName from(String name, PurgomalumClient purgomalumClient) {
+        if (name == null || name.isEmpty()) {
+            throw new IllegalArgumentException("상품명은 필수로 입력해야 합니다.");
+        }
+
+        if (purgomalumClient.containsProfanity(name)) {
+            throw new IllegalArgumentException("비속어가 포함되어 있습니다.");
+        }
+        return new ProductName(name);
+    }
+
+    public String getName() {
+        return name;
+    }
+}

src/main/java/kitchenpos/products/tobe/domain/ProductPrice.java

@@ -0,0 +1,33 @@
+package kitchenpos.products.tobe.domain;
+
+import jakarta.persistence.Column;
+import jakarta.persistence.Embeddable;
+import java.math.BigDecimal;
+
+@Embeddable
+public class ProductPrice {
+
+    @Column(name = "price", nullable = false)
+    private BigDecimal price;
+
+    protected ProductPrice() {}
+
+    private ProductPrice(BigDecimal price) {
+        this.price = price;
+    }
+
+    public static ProductPrice from(BigDecimal price) {
+        validate(price);
+        return new ProductPrice(price);
+    }
+
+    private static void validate(BigDecimal price) {
+        if (price == null || price.compareTo(BigDecimal.ZERO) < 0) {
+            throw new IllegalArgumentException("가격은 0 이상이어야 합니다.");
+        }
+    }
+
+    public BigDecimal getPrice() {
+        return price;
+    }
+}

src/main/java/kitchenpos/products/tobe/domain/ProductRepository.java

@@ -0,0 +1,16 @@
+package kitchenpos.products.tobe.domain;
+
+import java.util.List;
+import java.util.Optional;
+import java.util.UUID;
+
+public interface ProductRepository {
+    Product save(Product product);
+
+    Optional<Product> findById(UUID id);
+
+    List<Product> findAll();
+
+    List<Product> findAllByIdIn(List<UUID> ids);
+}
+