🚀 1단계 - 리팩터링(상품)

docker-compose.yml

@@ -0,0 +1,20 @@
+version: '3.8'
+
+services:
+  mysql:
+    image: mysql:8.0
+    container_name: kitchenpos-mysql
+    restart: always
+    environment:
+      MYSQL_ROOT_PASSWORD: root
+      MYSQL_DATABASE: kitchenpos
+      MYSQL_USER: user
+      MYSQL_PASSWORD: password
+    ports:
+      - "33306:3306"
+    command: --default-authentication-plugin=mysql_native_password
+    volumes:
+      - mysql_data:/var/lib/mysql
+
+volumes:
+  mysql_data:

src/main/java/kitchenpos/menus/application/MenuService.java

@@ -7,7 +7,7 @@
 import kitchenpos.menus.domain.MenuRepository;
 import kitchenpos.products.domain.Product;
 import kitchenpos.products.domain.ProductRepository;
-import kitchenpos.products.infra.PurgomalumClient;
+import kitchenpos.shared.domain.ProfanityChecker;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
@@ -23,18 +23,18 @@ public class MenuService {
     private final MenuRepository menuRepository;
     private final MenuGroupRepository menuGroupRepository;
     private final ProductRepository productRepository;
-    private final PurgomalumClient purgomalumClient;
+    private final ProfanityChecker profanityChecker;
 
     public MenuService(
         final MenuRepository menuRepository,
         final MenuGroupRepository menuGroupRepository,
         final ProductRepository productRepository,
-        final PurgomalumClient purgomalumClient
+        final ProfanityChecker profanityChecker
     ) {
         this.menuRepository = menuRepository;
         this.menuGroupRepository = menuGroupRepository;
         this.productRepository = productRepository;
-        this.purgomalumClient = purgomalumClient;
+        this.profanityChecker = profanityChecker;
     }
 
     @Transactional
@@ -79,7 +79,7 @@ public Menu create(final Menu request) {
             throw new IllegalArgumentException();
         }
         final String name = request.getName();
-        if (Objects.isNull(name) || purgomalumClient.containsProfanity(name)) {
+        if (Objects.isNull(name) || profanityChecker.containsProfanity(name)) {
             throw new IllegalArgumentException();
         }
         final Menu menu = new Menu();

src/main/java/kitchenpos/products/application/ProductService.java

@@ -5,7 +5,7 @@
 import kitchenpos.menus.domain.MenuRepository;
 import kitchenpos.products.domain.Product;
 import kitchenpos.products.domain.ProductRepository;
-import kitchenpos.products.infra.PurgomalumClient;
+import kitchenpos.shared.domain.ProfanityChecker;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
@@ -19,16 +19,16 @@
 public class ProductService {
     private final ProductRepository productRepository;
     private final MenuRepository menuRepository;
-    private final PurgomalumClient purgomalumClient;
+    private final ProfanityChecker profanityChecker;
 
     public ProductService(
         final ProductRepository productRepository,
         final MenuRepository menuRepository,
-        final PurgomalumClient purgomalumClient
+        final ProfanityChecker profanityChecker
     ) {
         this.productRepository = productRepository;
         this.menuRepository = menuRepository;
-        this.purgomalumClient = purgomalumClient;
+        this.profanityChecker = profanityChecker;
     }
 
     @Transactional
@@ -38,7 +38,7 @@ public Product create(final Product request) {
             throw new IllegalArgumentException();
         }
         final String name = request.getName();
-        if (Objects.isNull(name) || purgomalumClient.containsProfanity(name)) {
+        if (Objects.isNull(name) || profanityChecker.containsProfanity(name)) {
             throw new IllegalArgumentException();
         }
         final Product product = new Product();

src/main/java/kitchenpos/products/infra/TobeJpaProductRepository.java

@@ -0,0 +1,9 @@
+package kitchenpos.products.infra;
+
+import kitchenpos.products.tobe.domain.Product;
+import kitchenpos.products.tobe.domain.ProductId;
+import kitchenpos.products.tobe.domain.TobeProductRepository;
+import org.springframework.data.jpa.repository.JpaRepository;
+
+public interface TobeJpaProductRepository extends TobeProductRepository, JpaRepository<Product, ProductId> {
+}

src/main/java/kitchenpos/products/tobe/domain/Product.java

@@ -0,0 +1,52 @@
+package kitchenpos.products.tobe.domain;
+
+import jakarta.persistence.*;
+import kitchenpos.shared.domain.DomainEntity;
+import kitchenpos.shared.domain.Money;
+
+import java.math.BigDecimal;
+import java.util.Objects;
+import java.util.UUID;
+
+@Table(name = "product_tobe")
+@Entity(name = "ProductTobe")
+public class Product extends DomainEntity<Product, ProductId> {
+
+    @EmbeddedId
+    @AttributeOverride(name = "value", column = @Column(name = "id"))
+    private ProductId id;
+
+    @Embedded
+    @AttributeOverride(name = "name", column = @Column(name = "name", nullable = false))
+    private ProductName name;
+
+    @Embedded
+    @AttributeOverride(name = "price", column = @Column(name = "price", nullable = false))
+    private ProductPrice price;
+
+    @SuppressWarnings("unused")
+    protected Product() {}
+
+    private Product(ProductId id, ProductName name, ProductPrice price) {
+        this.id = Objects.requireNonNull(id, "id must not be null");
+        this.name = Objects.requireNonNull(name, "name must not be null");
+        this.price = Objects.requireNonNull(price, "price must not be null");
+    }
+
+    public static Product create(ProductId id, ProductName name, ProductPrice price) {
+        return new Product(id, name, price);
+    }
+
+    /**
+     * getter
+     */
+    @Override
+    public ProductId getId() {
+        return id;
+    }
+
+    public ProductName getName() { return name; }
+
+    public ProductPrice getPrice() { return price; }
+
+}

src/main/java/kitchenpos/products/tobe/domain/ProductId.java

@@ -0,0 +1,30 @@
+package kitchenpos.products.tobe.domain;
+
+import jakarta.persistence.Embeddable;
+import kitchenpos.products.tobe.domain.exception.InvalidProductIdException;
+
+import java.io.Serializable;
+
+@Embeddable
+public class ProductId implements Serializable {
+
+    private String value;
+
+    @SuppressWarnings("unused")
+    protected ProductId() {}
+
+    private ProductId(String value) {
+        if (value == null || value.isBlank()) {
+            throw new InvalidProductIdException("Product ID 는 null 이거나 빈 값이 될 수 없습니다.");
+        }
+        this.value = value.strip();
+    }
+
+    public static ProductId of(String value) {
+        return new ProductId(value);
+    }
+
+    public String getValue() {
+        return value;
+    }
+}

src/main/java/kitchenpos/products/tobe/domain/ProductIdGenerator.java

@@ -0,0 +1,5 @@
+package kitchenpos.products.tobe.domain;
+
+public interface ProductIdGenerator {
+    ProductId generateId();
+}

src/main/java/kitchenpos/products/tobe/domain/ProductName.java

@@ -0,0 +1,42 @@
+package kitchenpos.products.tobe.domain;
+
+import jakarta.persistence.Embeddable;
+import jakarta.persistence.Transient;
+import kitchenpos.products.tobe.domain.exception.InvalidProductNameException;
+import kitchenpos.shared.domain.ProfanityChecker;
+import kitchenpos.shared.domain.ValueObject;
+
+@Embeddable
+public class ProductName extends ValueObject<ProductName> {
+
+    private String name;
+
+    @SuppressWarnings("unused")
+    protected ProductName() {}
+
+    // 외부에서 직접 호출할 수 없는 private 생성자: 검증된 이름만 받음
+    private ProductName(String name) {
+        this.name = name;
+    }
+
+    public static ProductName create(ProfanityChecker profanityChecker, String name) {
+        if (name == null || name.isBlank()) {
+            throw new InvalidProductNameException("Product name 은 null 이거나 빈 값이 될 수 없습니다.");
+        }
+
+        if (profanityChecker.containsProfanity(name)) {
+            throw new InvalidProductNameException("Product name 에 비속어가 포함될 수 없습니다.");
+        }
+        return new ProductName(name.strip());
+    }
+
+    public String getName() {
+        return name;
+    }
+
+    @Override
+    @Transient
+    protected Object[] getEqualityFields() {
+        return new Object[] { name };
+    }
+}

src/main/java/kitchenpos/products/tobe/domain/ProductPrice.java

@@ -0,0 +1,30 @@
+package kitchenpos.products.tobe.domain;
+
+import kitchenpos.products.tobe.domain.exception.InvalidProductPriceException;
+import kitchenpos.shared.domain.Money;
+import kitchenpos.shared.domain.ValueObject;
+
+public class ProductPrice extends ValueObject<ProductPrice> {
+    private Money price;
+
+    private ProductPrice(Money price) {
+        if (price == null || price.isLessThan(Money.ZERO)) {
+            throw new InvalidProductPriceException("상품 가격은 null 이거나 0보다 작을 수 없습니다.");
+        }
+
+        this.price = price;
+    }
+
+    public static ProductPrice of(Money price) {
+        return new ProductPrice(price);
+    }
+
+    public Money getPrice() {
+        return price;
+    }
+
+    @Override
+    protected Object[] getEqualityFields() {
+        return new Object[] { price };
+    }
+}

src/main/java/kitchenpos/products/tobe/domain/TobeProductRepository.java

@@ -0,0 +1,20 @@
+package kitchenpos.products.tobe.domain;
+
+import org.springframework.stereotype.Repository;
+import org.springframework.transaction.annotation.Transactional;
+
+import java.util.List;
+import java.util.Optional;
+
+@Repository
+@Transactional
+public interface TobeProductRepository {
+    Product save(Product product);
+
+    Optional<Product> findById(ProductId id);
+
+    List<Product> findAll();
+
+    List<Product> findAllByIdIn(List<ProductId> ids);
+}
+

src/main/java/kitchenpos/products/tobe/domain/exception/InvalidProductIdException.java

@@ -0,0 +1,7 @@
+package kitchenpos.products.tobe.domain.exception;
+
+public class InvalidProductIdException extends IllegalArgumentException {
+    public InvalidProductIdException(String s) {
+        super(s);
+    }
+}

src/main/java/kitchenpos/products/tobe/domain/exception/InvalidProductNameException.java

@@ -0,0 +1,7 @@
+package kitchenpos.products.tobe.domain.exception;
+
+public class InvalidProductNameException extends IllegalArgumentException {
+    public InvalidProductNameException(String s) {
+        super(s);
+    }
+}

src/main/java/kitchenpos/products/tobe/domain/exception/InvalidProductPriceException.java

@@ -0,0 +1,7 @@
+package kitchenpos.products.tobe.domain.exception;
+
+public class InvalidProductPriceException extends IllegalArgumentException {
+    public InvalidProductPriceException(String s) {
+        super(s);
+    }
+}

src/main/java/kitchenpos/products/tobe/domain/support/UUIDBasedProductIdGenerator.java

@@ -0,0 +1,15 @@
+package kitchenpos.products.tobe.domain.support;
+
+import kitchenpos.products.tobe.domain.ProductId;
+import kitchenpos.products.tobe.domain.ProductIdGenerator;
+import org.springframework.stereotype.Component;
+
+import java.util.UUID;
+
+@Component
+public class UUIDBasedProductIdGenerator implements ProductIdGenerator {
+    @Override
+    public ProductId generateId() {
+        return ProductId.of(UUID.randomUUID().toString());
+    }
+}

src/main/java/kitchenpos/shared/domain/DomainEntity.java

@@ -0,0 +1,37 @@
+package kitchenpos.shared.domain;
+
+import java.io.Serializable;
+
+public abstract class DomainEntity<T extends DomainEntity<T, TID>, TID> implements Serializable {
+    @Override
+    public boolean equals(Object other) {
+        if (other == null) {
+            return false;
+        }
+
+        return equals((T)other);
+    }
+
+    public boolean equals(T other) {
+        if (other == null) {
+            return false;
+        }
+
+        if (getId() == null) {
+            return false;
+        }
+
+        if (other.getClass().equals(getClass())) {
+            return getId().equals(other.getId());
+        }
+
+        return super.equals(other);
+    }
+
+    @Override
+    public int hashCode() {
+        return getId() == null ? 0 : getId().hashCode();
+    }
+
+    abstract public TID getId();
+}