-
Notifications
You must be signed in to change notification settings - Fork 213
[10기 soonysoo] TodoList with CRUD #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
soonysoo
wants to merge
11
commits into
next-step:soonysoo
Choose a base branch
from
soonysoo:soonysoo
base: soonysoo
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5a98520
프로젝트 구성
soonysoo 24ef8da
App component 구조화
soonysoo 083007d
App구조화
soonysoo 5cb9313
component 생성
soonysoo be55af2
onaddtodo 기능구현
soonysoo 76d96d8
state수정
soonysoo 023bf9e
delete activate 기능 구현
soonysoo 1fb2b3a
Filtering 기능구현
soonysoo e3074f6
updateTodo 기능 구현
soonysoo 11807be
요구사항
soonysoo ab1f0c9
[refactoring] util기능 분류
soonysoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,26 @@ | ||
| import Component from "../core/component.js"; | ||
| import Component from "../core/component.js"; | ||
|
|
||
| class Filter extends Component{ | ||
| setup(){ | ||
|
|
||
| } | ||
|
|
||
| template(){ | ||
| return ` | ||
| <span class="todo-count">총 <strong>0</strong> 개</span> | ||
| <ul class="filters"> | ||
| <li> | ||
| <a class="all selected" href="#">전체보기</a> | ||
| </li> | ||
| <li> | ||
| <a class="active" href="#active">해야할 일</a> | ||
| </li> | ||
| <li> | ||
| <a class="completed" href="#completed">완료한 일</a> | ||
| </li> | ||
| </ul> | ||
| ` | ||
| } | ||
| } | ||
|
|
||
| export default Filter; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,13 @@ | ||
| import Component from "../core/component.js"; | ||
| import Component from "../core/component.js"; | ||
|
|
||
| class Input extends Component{ | ||
| setup(){ | ||
|
|
||
| } | ||
|
|
||
| template(){ | ||
|
|
||
| } | ||
| } | ||
|
|
||
| export default Input; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,38 @@ | ||
| import Component from "../core/component.js"; | ||
| import Component from "../core/component.js"; | ||
|
|
||
| class TodoList extends Component{ | ||
| setup(){ | ||
|
|
||
| } | ||
|
|
||
| template(){ | ||
| return ` | ||
| <li> | ||
| <div class="view"> | ||
| <input class="toggle" type="checkbox"/> | ||
| <label class="label">새로운 타이틀</label> | ||
| <button class="destroy"></button> | ||
| </div> | ||
| <input class="edit" value="새로운 타이틀" /> | ||
| </li> | ||
| <li class="editing"> | ||
| <div class="view"> | ||
| <input class="toggle" type="checkbox" /> | ||
| <label class="label">완료된 타이틀</label> | ||
| <button class="destroy"></button> | ||
| </div> | ||
| <input class="edit" value="완료된 타이틀" /> | ||
| </li> | ||
| <li class="completed"> | ||
| <div class="view"> | ||
| <input class="toggle" type="checkbox" checked/> | ||
| <label class="label">완료된 타이틀</label> | ||
| <button class="destroy"></button> | ||
| </div> | ||
| <input class="edit" value="완료된 타이틀" /> | ||
| </li> | ||
| ` | ||
| } | ||
| } | ||
|
|
||
| export default TodoList; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시, 전체를 템플릿으로 한 부분이 궁금해요. ^^
저렇게 하면, 데이터를 변하는 부분과 고정된 부분을 구별해서 가져오는 것이 쉽지 않을 것 같아서요.
제가 FE를 사용을 잘 몰라서 하는 이야기일 수도 있어요. 그냥 참고만 하셔도 됩니다.