-
Notifications
You must be signed in to change notification settings - Fork 164
[Spring MVC] 박시원 미션 제출합니다. #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
8parks
wants to merge
2
commits into
next-step:8parks
Choose a base branch
from
8parks:step12
base: 8parks
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
// 어드민 페이지 home.html 반환 | ||
package roomescape; | ||
|
||
import org.springframework.stereotype.Controller; | ||
import org.springframework.web.bind.annotation.GetMapping; | ||
|
||
@Controller | ||
public class HomeController { | ||
|
||
// 어드민 메인 페이지 홈 화면 반환 (요구사항) | ||
@GetMapping("/") | ||
public String home() { | ||
return "home"; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
package roomescape; | ||
|
||
public class Reservation { | ||
private Long id; | ||
private String name; | ||
private String date; | ||
private String time; | ||
|
||
public Reservation(Long id, String name, String date, String time) { | ||
this.id = id; | ||
this.name = name; | ||
this.date = date; | ||
this.time = time; | ||
} | ||
|
||
public Long getId() { | ||
return id; | ||
} | ||
|
||
public String getName() { | ||
return name; | ||
} | ||
|
||
public String getDate() { | ||
return date; | ||
} | ||
|
||
public String getTime() { | ||
return time; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
package roomescape; | ||
|
||
import java.util.*; | ||
import org.springframework.stereotype.Controller; | ||
import org.springframework.web.bind.annotation.GetMapping; | ||
import org.springframework.web.bind.annotation.ResponseBody; | ||
|
||
@Controller | ||
public class ReservationController { | ||
|
||
private List<Reservation> reservations = new ArrayList<>(); | ||
|
||
public ReservationController() { | ||
reservations.add(new Reservation(1L, "브라운", "2023-01-01", "10:00")); | ||
reservations.add(new Reservation(2L, "브라운", "2023-01-02", "11:00")); | ||
} | ||
|
||
// /reservation 요청 시 html 응답 | ||
@GetMapping("/reservation") | ||
public String reservation() { | ||
return "reservation"; | ||
} | ||
|
||
// /reservations 예약 목록 조회 요청 처리 | ||
@GetMapping("/reservations") | ||
@ResponseBody | ||
public List<Reservation> getReservations() { | ||
return reservations; | ||
} | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add()
로 초기 데이터를 넣으면 리스트가 mutable 상태가 됩니다.테스트용 고정 데이터라면
List.of()
로 불변 리스트로 선언해도 좋을 것 같아요. 선택은 자유입니다. 혹시 가변 리스트 생성을 한 특별한 이유가 있을까요?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하 감사합니다! 특별한 이유는 따로 없고,
List.of()
으로 쓰는 것을 생각하지 못했습니다..ㅎㅎ 개인적으로 ArrayList가 제일 익숙하기도 하고 직전에 컨트롤러 CRUD 실습을 했어서 ArrayList로 그냥 자연스럽게 썼던 것 같아요. 다음에는 이런 부분도 더 신경 써보겠습니다!!