Update docs for usage with ESM / ES6 #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing docs show a relative path, not the actual npm module bundle path. I believe this should be correct for ESM/ES6 type environments and will hopefully prevent confusion as found in nextapps-de#341 etc.
|
This worked for me, thanks a million! I think updating the docs would help until #343 is finished. |
|
@jorgebg glad it helped! Hopefully @ts-thomas has a chance to review and merge (or improve) so other devs aren't confused. |
|
@danawoodman You're awesome. Thank you for your effort |
|
Awesome pull request. Please merge! This is the way to import Flexsearch in a Vite (etc.) project. |
|
Glad it helped yall! |
|
Following up on this, any chance it gets merged in so it can help others? |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing docs show a relative path, not the actual npm module bundle path.
I believe this should be correct for ESM/ES6 type environments and will hopefully prevent confusion as found in #341 etc.