Remove incorrect types to reduce maintenance overhead #405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the typescript type declarations.
As already mentioned in #342, #392 and #364, the types shipped with this package are plain incorrect. This is an issue every developer has to work around when using this package together with typescript.
I can tell that this package is basically abandoned, so I decided to remove the
index.d.ts
instead of patching it as #364 did.This ensures minimal maintenance effort, while allowing other motivated developers to publish correct types in
@types/flexsearch
.@ts-thomas Please take five minutes to merge and publish this so that hundreds (or even thousands) of developers do not have to invest five minutes each to work around this every time they want to install this package. (As a small incentive 🙈 I even sponsored you for this)
Thank you for the amazing package!