Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add qwik framework #21

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shane-Donlon
Copy link

☕️ Reasoning

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Hi team,
Apologies I didn't add this as an issue before.

When running npm exec auth secret for a Qwik Project I was getting the below error.
No framework detected. Currently supported frameworks are: next, sveltekit, express
No documentation changes.

The changes I have suggested resolve this.

Also for awareness when Qwik V2 is released in the future the name will be updated.
This or statement will capture Qwik V1 & Qwik V2,

    if (
      packageJson?.devDependencies?.["@qwik.dev/router"] ||
      packageJson?.devDependencies?.["@builder.io/qwik-city"]
    ) {
      foundFrameworks.push("qwik")
    }

I did test this NPM link and works for both V1 & V2.

if .env.local file exists

  • append AUTH_SECRET to already existing .env.local file
    if not .env.local file exists
  • creates .env.local file and adds AUTH_SECRET to the file.

I hope this PR is welcome ❤️

Notes:
This PR is in draft status as I did not log an issue,
if the PR is welcome I can update from draft status.

Thank you!

📌 Resources

@gioboa
Copy link

gioboa commented Feb 4, 2025

Thanks @Shane-Donlon for your help 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants