Fix: Add fallback for multiple frameworks #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
🧢 Checklist
🎫 Affected issues
Fixes #20
Hi team,
Came across this issue yesterday and had a few minutes today.
In short if multiple frameworks are detected the below will be the terminal output.
(Confirmed copy to clipboard as working)
if copy to clipboard fails
the auth secret will still be added to the terminal for the Developer to add to their own file / files.
I also added a little bit of error handling to detect.js
The thinking here was that since the origin return is "unknown" this would cause 2 error messages as highlighted below
error one in line 38
https://github.com/nextauthjs/cli/blob/main/lib/detect.js#L38
error 2 in line 46
https://github.com/nextauthjs/cli/blob/main/lib/detect.js#L46
Which is a potential cause of confusion (as highlighted in Issue 20)
I opted to just end the process after the error.
Feedback welcome.
Have a great day.
📌 Resources