-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blitz Auth Adapter #8011
Blitz Auth Adapter #8011
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@siddhsuresh is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'm happy to help move this forward!
next-auth
will remain Next.js specific, and we do not plan to expose internal APIs, so this PR in its current form won't be accepted. I'm happy to investigate though how we can make @auth/core
more flexible, which is the intended package for library/framework authors to build on top of.
Note that #7443 is going to refactor the internals of next-auth
significantly, so that is another reason these changes are not going to work in the long term.
Hey @balazsorban44 thank you for the quick response! Understood. I have reverted the changes regarding exposing internals of I am yet to get a proper development environment here, so I cannot say for certain. But during my research process before building the current adapter, I found that I needed these 3 functions from This will allow us to pivot our adapter to work directly with |
Can you point me where these are invoked in blitz? |
@balazsorban44 here, |
Hey @balazsorban44, would you like me to re implement this with |
72e1831
to
c0f9af4
Compare
☕️ Reasoning
Hello @balazsorban44! I hope you're doing well. I wanted to reach out as one of the maintainers of blitz-js. In our efforts to enhance blitz, we have developed an adapter that works in conjunction with next-auth to provide users with the ability to utilize blitz-auth API seamlessly with next-auth's OAuth providers.
Throughout our development process, we encountered several obstacles while utilizing next-auth's Internal API directly (as expected). As a result, we have initiated a pull request (PR) to address these challenges.
This PR will facilitate us to make the adapter more stable, rather than relying on runtime patching and allow other external libraries to be build on top of
@auth/core
andnext-auth
.Thank you.
🧢 Checklist
🎫 Affected issues
Fixes: #7941 blitz-js/blitz#4143 blitz-js/blitz#4171
📌 Resources