Skip to content

Update @babel/core @babel/eslint-parser eslint-config-standard eslint…#231

Closed
skjnldsv wants to merge 1 commit intomasterfrom
dependaskjnldsv/various
Closed

Update @babel/core @babel/eslint-parser eslint-config-standard eslint…#231
skjnldsv wants to merge 1 commit intomasterfrom
dependaskjnldsv/various

Conversation

@skjnldsv
Copy link
Copy Markdown
Contributor

@skjnldsv skjnldsv commented Nov 3, 2021

…-plugin-import eslint-plugin-promise and webpack

But not eslint 8: #230

…-plugin-import eslint-plugin-promise and webpack

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv requested review from Pytal, artonge and st3iny November 3, 2021 14:20
@skjnldsv skjnldsv added dependencies Pull requests that update a dependency file enhancement New feature or request labels Nov 3, 2021
@artonge
Copy link
Copy Markdown
Contributor

artonge commented Nov 3, 2021

Might be better to keep webpack under 5.48.0. As said webpack >= 5.48.0 breaks probably most of our Node CI because we want reproducible sourcemaps and this workaround does not work anymore.

I opened this PR but I am really not sure about the content...

Copy link
Copy Markdown
Contributor

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the breaking webpack minor, should be good 🚀

@Pytal
Copy link
Copy Markdown
Contributor

Pytal commented Nov 4, 2021

Did not know that this repo allows just one approval, hope no one accidently merges before downgrade 🤞

@skjnldsv skjnldsv closed this Jan 12, 2022
@skjnldsv skjnldsv deleted the dependaskjnldsv/various branch January 12, 2022 11:24
susnux pushed a commit that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants