feat(dialogs): allow to quickly show a dialog #1986
Merged
+118
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1986 +/- ##
==========================================
+ Coverage 43.33% 49.93% +6.60%
==========================================
Files 22 22
Lines 773 803 +30
Branches 93 102 +9
==========================================
+ Hits 335 401 +66
+ Misses 437 401 -36
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
susnux
force-pushed
the
feat/quick-dialog
branch
from
b9065f2 to
17da271
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/quick-dialog
branch
from
17da271 to
86e8589
Compare
|
rebased |
CarlSchwan
approved these changes
Oct 6, 2025
skjnldsv
approved these changes
Oct 7, 2025
|
Confirm dialogs seem to me to be a part of UI Kit. Why add them here and not in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often its quite useful to just spin up a very simple dialog without need of using the builder.
(had this floating around for some time, so added tests now and created this PR :) ).