Skip to content

fix: timezone width breaking the timeslots #6350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jan 6, 2025

☑️ Resolves

if someone has a better idea, please let me know

🖼️ Screenshots

🏚️ Before 🏡 After

after
Screenshot from 2025-01-06 11-56-57

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@GretaD GretaD added bug Something isn't working 3. to review Waiting for reviews labels Jan 6, 2025
@GretaD GretaD requested review from susnux, ShGKme and GVodyanov January 6, 2025 10:58
@GretaD GretaD self-assigned this Jan 6, 2025
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the width of all selects in all the apps making them 260px.

Instead, it can have max-width: 100%; so it doesn't overflow the container. But I'm not sure it should be done in the component. I'd check that it doesn't break anything first, or just do it in place, in the Calendar.

@GretaD
Copy link
Contributor Author

GretaD commented Jan 7, 2025

I can also do it on calendar only if its too messy on the nc/vue component

@GretaD
Copy link
Contributor Author

GretaD commented Jan 8, 2025

lets do it on calendar

@GretaD GretaD closed this Jan 8, 2025
@susnux susnux deleted the fix/timezone-width branch April 2, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Appointment Schedule view breaks with some selected time zones
2 participants