fix: animate toggle switch icon #8045
Merged
+81
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Contributor
Author
|
/backport to stable8 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8045 +/- ##
==========================================
+ Coverage 53.25% 53.28% +0.02%
==========================================
Files 101 102 +1
Lines 3145 3147 +2
Branches 872 871 -1
==========================================
+ Hits 1675 1677 +2
+ Misses 1232 1231 -1
- Partials 238 239 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kra-mo
approved these changes
Dec 30, 2025
Antreesy
approved these changes
Dec 30, 2025
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Tested in app, looks good
susnux
reviewed
Dec 30, 2025
| </style> | ||
|
|
||
| <docs> | ||
| Private component |
Contributor
There was a problem hiding this comment.
Maybe expose it just like NcLoadingIcon?
Contributor
Author
There was a problem hiding this comment.
IMO, existing components should cover all the cases of toggle switches. Loading icon, in contrast, is used directly in most of the cases because we don't have any alternatives like loading states of containers/buttons/inputs.
susnux
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🏁 Checklist
stable8for maintained Vue 2 version or not applicable