[stable8] fix(NcModal): Adjust max height to leave some space #8046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
requested review from
Antreesy,
ShGKme,
jancborchardt,
kra-mo and
susnux
backportbot
bot
added
bug
This is so that the modal doesn't exactly touch the edges of the header, which looks a bit weird. Signed-off-by: Laura Kramolis <[email protected]> Signed-off-by: kramo <[email protected]>
ShGKme
approved these changes
Dec 30, 2025
Antreesy
approved these changes
Dec 30, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stable8 #8046 +/- ##
========================================
Coverage 45.48% 45.48%
========================================
Files 192 192
Lines 4769 4769
Branches 1172 1172
========================================
Hits 2169 2169
Misses 2508 2508
Partials 92 92 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jancborchardt
approved these changes
Jan 5, 2026
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #8042