Skip to content

Conversation

@rotdrop
Copy link

@rotdrop rotdrop commented Jun 20, 2025

Please refer also or even primarily to the discussions of the respective issues and PRs of the upstream Sabre project:

This is a backport of the (not yet accepted) PR sabre-io/vobject#716

The base of the PR is that in my user community we have a wild mixture of users (Windoze, half-eaten-apple, me as Linux guy), and this case of mixed RRULE and RDATE just occurs, example:

DTSTART;TZID=Europe/Berlin:20250703T190000
DTEND;TZID=Europe/Berlin:20250703T210000
RRULE:FREQ=WEEKLY;UNTIL=20370101T225959Z;INTERVAL=4;BYDAY=TH
RDATE=;TZID=Europe/Berlin:20250424T193000

This is fully supported by the CalDAV standard which states that the total recurrence-set is just the union of the events defined by RRULE as well as RDATE directives.

@rotdrop rotdrop force-pushed the bugfix/sabre-supprot-rrules-with-rdates branch from 05fd96b to f00eac9 Compare June 20, 2025 18:57
@rotdrop
Copy link
Author

rotdrop commented Jun 20, 2025

Oops. This should be modelled in the context of cweagans/composer-patches. Ok. I'll eventually do this.

@rotdrop rotdrop force-pushed the bugfix/sabre-supprot-rrules-with-rdates branch from f00eac9 to e6493f1 Compare June 21, 2025 10:36
@rotdrop
Copy link
Author

rotdrop commented Jun 21, 2025

Oops. This should be modelled in the context of cweagans/composer-patches. Ok. I'll eventually do this.

Refactored using composer-patches framework.

@susnux susnux requested a review from ChristophWurst July 14, 2025 21:51
@ChristophWurst ChristophWurst requested review from SebastianKrupinski and st3iny and removed request for ChristophWurst July 15, 2025 08:33
@SebastianKrupinski
Copy link
Contributor

Hi @rotdrop

We are not apposed to these changes but will need to review and test them first.

Please give us a bit of time to do so.

@SebastianKrupinski
Copy link
Contributor

@rotdrop

I commented on your PR in the SabreDAV repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants