more accurate error messages

[unglaublicherdude]

this just cost me some hours, searching for a malformed activity_id

[artonge]

Thanks !

[artonge]

@unglaublicherdude can you fix DCO, and also commit the result of npm run build?

[artonge]

Not there yet @unglaublicherdude

[unglaublicherdude]

It is weird. When I run

npm ci
npm run build --if-present

I get this:

git diff -a
diff --git a/js/vendor.LICENSE.txt b/js/vendor.LICENSE.txt
index 338efa90..79e5b708 100644
--- a/js/vendor.LICENSE.txt
+++ b/js/vendor.LICENSE.txt
@@ -53,7 +53,7 @@ version: 2.1.0
 license: GPL-3.0-or-later
 
 @nextcloud/l10n
-version: 3.1.0
+version: 2.2.0
 license: GPL-3.0-or-later
 
 @nextcloud/logger

While its still this version:

  "dependencies": {
[...]
    "@nextcloud/l10n": "^3.1.0",

[artonge]

Maybe a matter of npm or nodejs versions?

[unglaublicherdude]

I added a devcontainer for that where I have those version.

vscode ➜ /workspaces/activity (master) $ node --version
v20.13.1
vscode ➜ /workspaces/activity (master) $ npm --version
10.5.2

They match, whats required in the packages.json

  "engines": {
    "node": "^20.0.0",
    "npm": "^10.0.0"
  },

[unglaublicherdude]

I deleted my commit and made a new one. The npm run did not change the licence file. But I guess the pipeline will still fail, because with the npm run build in the pipeline it will again create it, right?

Like it did in my second try:
https://github.com/nextcloud/activity/actions/runs/9266274710/job/25490812190

[artonge]

@unglaublicherdude I tried on my computer, and the LICENCE.txt is properly updated. Could you try again? Maybe you also need to delete your node_modules first.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[susnux]

Rebase gone wrong, sorry!
Copy can be found here: #1757