Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/remote activity constructor #1811

Merged
merged 2 commits into from
Oct 14, 2024
Merged

fix/remote activity constructor #1811

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a51d666
fix: Properly call parent constructor for remote activity job
juliusknorr Oct 14, 2024
cc0ff11
chore: Move to property promotion for RemoteActivity job
juliusknorr Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions lib/BackgroundJob/RemoteActivity.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,19 @@

use GuzzleHttp\Exception\ClientException;
use OCA\Activity\Extension\Files;
use OCP\AppFramework\Utility\ITimeFactory;
use OCP\BackgroundJob\QueuedJob;
use OCP\Federation\ICloudId;
use OCP\Federation\ICloudIdManager;
use OCP\Http\Client\IClientService;

class RemoteActivity extends QueuedJob {
/** @var IClientService */
protected $clientService;

/** @var ICloudIdManager */
protected $cloudIdManager;

public function __construct(IClientService $clientService, ICloudIdManager $cloudIdManager) {
$this->clientService = $clientService;
$this->cloudIdManager = $cloudIdManager;
public function __construct(
ITimeFactory $timeFactory,
private readonly IClientService $clientService,
private readonly ICloudIdManager $cloudIdManager,
) {
parent::__construct($timeFactory);
}

protected function run($argument) {
Expand Down
Loading