Revert "[stable28] fix/remote activity constructor" #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GretaD
approved these changes
Nov 15, 2024
Activity
|
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
revert-1813-backport/1811/stable28
|
| Run status |
|
| Run duration | 01m 43s |
| Commit |
|
| Committer | Julius Knorr |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
3
|
Skipped
|
0
|
Passing
|
7
|
| View all changes introduced in this branch ↗︎ | |
juliusknorr
force-pushed
the
revert-1813-backport/1811/stable28
branch
from
fae456b to
14607f7
Compare
Signed-off-by: Julius Knorr <[email protected]>
juliusknorr
force-pushed
the
revert-1813-backport/1811/stable28
branch
from
14607f7 to
4c79562
Compare
|
php-cs also fails on other prs, seems unrelated (#1705) |
Closed
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1813 as the code in 28 does not have the original issue.
The bug was only introduced in c8248b0 for 29 and later