-
Notifications
You must be signed in to change notification settings - Fork 936
Update reverse-proxy.md #6226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update reverse-proxy.md #6226
Conversation
Adding prominent hint to Traefik users adding the Traefik container to the aio network to change the server domain during the installation process. The nextcloud-aio-apache container is not in place as indicated in the documentation at this point in time Signed-off-by: DaCHack <[email protected]>
| loadBalancer: | ||
| servers: | ||
| #When adding Traefik to the aio network: This needs to be changed in the installation process! Point this to nextcloud-aio-domaincheck first, then change to nextcloud-aio-apache after the domaincheck | ||
| - url: "http://localhost:11000" # Adjust to match APACHE_PORT and APACHE_IP_BINDING. See https://github.com/nextcloud/all-in-one/blob/main/reverse-proxy.md#adapting-the-sample-web-server-configurations-below |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, if you read through the documentation mentioned here: https://github.com/nextcloud/all-in-one/blob/main/reverse-proxy.md#adapting-the-sample-web-server-configurations-below, you would have seen that pointing at nextcloud-aio-apache is the solution to your problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was actually the Root cause of my problem. Apache does not get created at the Point of the domaincheck. Thus, nextcloud-aio-apache cannot be found by Traefik.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be a problem as the domaincheck container uses an alias:
all-in-one/php/src/Docker/DockerActionManager.php
Lines 945 to 948 in 13e9829
| // Add a secondary alias for domaincheck container, to keep it as similar to actual apache controller as possible. | |
| // If a reverse-proxy is relying on container name as hostname this allows it to operate as usual and still validate the domain | |
| // The domaincheck container and apache container are never supposed to be active at the same time because they use the same APACHE_PORT anyway, so this doesn't add any new constraints. | |
| $alias = ($container->GetIdentifier() === 'nextcloud-aio-domaincheck') ? 'nextcloud-aio-apache' : ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting! Seems this did not work for me. Traefik always reported there is no such host.
Adding prominent hint to Traefik users adding the Traefik container to the aio network to change the server domain during the installation process. The nextcloud-aio-apache container is not in place as indicated in the documentation at this point in time