standardize ca-config #7217
Draft
standardize ca-config #7217
+67
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon L. <[email protected]>
33 tasks
szaimen
commented
Nov 28, 2025
| echo "" >> "$CERTIFICATE_BUNDLE" | ||
|
|
||
| # Check if variable is a simple switch. For example used by postgres and mysql tls connections | ||
| if [ "${!certificate}" != "yes" ]; then |
Collaborator
Author
There was a problem hiding this comment.
Should grep foe begin and end certificate
Collaborator
Author
There was a problem hiding this comment.
Should probably grep for BEGIN CERTIFICATE and END CERTIFICATE
Base automatically changed from
enh/noid/allow-configure-mysql-root-cert
to
main
December 3, 2025 11:43
22 tasks
szaimen
commented
Dec 3, 2025
szaimen
commented
Dec 5, 2025
| fi | ||
| } | ||
|
|
||
| create_global_root_cert() { |
Collaborator
Author
There was a problem hiding this comment.
the certs should only be written out once at container start if possible and not multiple times
szaimen
commented
Dec 5, 2025
|
|
||
| # Default vars | ||
| CERTIFICATES_ROOT_DIR="/var/www/html/data/certificates" | ||
| CERTIFICATE_BUNDLE="/var/www/html/resources/config/ca-bundle.crt" |
Collaborator
Author
There was a problem hiding this comment.
should use a different path now that we can specify one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the directive: Add the TLS_CACERT directive pointing to your certificate file: