Feat: respect reduced-motion settings #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
marcoambrosini
left a comment
marcoambrosini
left a comment
There was a problem hiding this comment.
Nice idea! I think it's better to just remove the animation in this case and treat the assistant icon like all other icons.
| /* Tone down the animation to avoid vestibular motion triggers. */ | ||
| @media (prefers-reduced-motion: reduce) { | ||
| .assistant-icon:hover .star1 { | ||
| animation: dissolve 1s linear; |
Member
There was a problem hiding this comment.
Suggested change
| animation: dissolve 1s linear; | |
| animation: none; | |
| opacity: 1; |
| } | ||
| .assistant-icon:hover .star2 { | ||
| animation: dissolve 1s linear; |
Member
There was a problem hiding this comment.
Suggested change
| animation: dissolve 1s linear; | |
| animation: none; | |
| opacity: 1; |
| } | ||
| .assistant-icon:hover .star3 { | ||
| animation: dissolve 1s linear; |
Member
There was a problem hiding this comment.
Suggested change
| animation: dissolve 1s linear; | |
| animation: none; | |
| opacity: 1; |
Comment on lines
89
to
93
| @keyframes dissolve { | ||
| 0% { opacity: 1; } | ||
| 50% { opacity: 0.5; } | ||
| 100% { opacity: 1; } | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| @keyframes dissolve { | |
| 0% { opacity: 1; } | |
| 50% { opacity: 0.5; } | |
| 100% { opacity: 1; } | |
| } |
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
janepie
force-pushed
the
feat/reduce-motion
branch
from
86a6575 to
dbb8080
Compare
janepie
changed the title
Member
Author
Done! Also deactivated the placeholder animation in the Chat UI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deactivates the icon animation and the placeholder movement when reduce-motion OS setting is set
CSS feature and how to activate it described here: https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion