Filter out task types that are declared as internal with the new IInternalTaskType #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
kyteinsky
approved these changes
Oct 9, 2025
Comment on lines
287
to
291
| // this appeared in 33, this is true if the task type class extends the IInternalTaskType | ||
| if ($taskTypeArray['isInternal'] ?? false) { |
…w IInternalTaskType Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/noid/filter-internal-task-types
branch
from
7275117 to
9538f05
Compare
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal task types should not appear in the assistant UI (not rendered in the generic form or any custom rendering).
For example, agency interaction or chat with tools are not directly related with a visible feature in the UI so they should be internal.
If an app wants to declare a non-AI task type, it should also be an internal.
refs nextcloud/server#55646