Fix audio recording and deal with audio watermarking in sub tasks #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Veyssier <[email protected]>
…port NC 33, adjust Php version in actions Signed-off-by: Julien Veyssier <[email protected]>
Member
Author
|
Maybe we should still support NC >= 30 and make dirty conditional stuff to disable watermarking. |
marcelklehr
reviewed
Dec 3, 2025
marcelklehr
reviewed
Dec 3, 2025
julien-nc
force-pushed
the
enh/noid/audio-adjustments
branch
from
0bea9af to
a5050a9
Compare
marcelklehr
reviewed
Dec 3, 2025
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/noid/audio-adjustments
branch
from
a5050a9 to
1ba5381
Compare
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/noid/audio-adjustments
branch
from
1ba5381 to
b1fb17c
Compare
Signed-off-by: Julien Veyssier <[email protected]>
marcelklehr
approved these changes
Dec 3, 2025
Member
marcelklehr
left a comment
marcelklehr
left a comment
There was a problem hiding this comment.
Tested and looks good. Maybe let's hold off on merging this so we can fix v2.10.0 first?
kyteinsky
reviewed
Dec 3, 2025
Contributor
kyteinsky
left a comment
kyteinsky
left a comment
There was a problem hiding this comment.
Stop transcoding wav to mp3 when recording audio. We now produce Wav files
was the transcoding not working properly?
…json Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/noid/audio-adjustments
branch
from
3f2c51a to
c13b3de
Compare
Member
Author
|
@kyteinsky It crashed at least for Marcel and Jana. Not sure why, not sure we can really figure it out. |
Signed-off-by: Julien Veyssier <[email protected]>
kyteinsky
approved these changes
Dec 4, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task::setIncludeWatermarkmethod exists)This requires adjustments in integration_openai (and maybe other providers) so they work when the assistant gives them Wav as audio input.