refactor: revert moment plugin factory pattern#6089
Merged
SebastianKrupinski merged 1 commit intomainfrom Aug 25, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6089 +/- ##
=======================================
Coverage 14.84% 14.84%
=======================================
Files 212 212
Lines 10272 10270 -2
Branches 2475 2464 -11
=======================================
Hits 1525 1525
+ Misses 8397 8395 -2
Partials 350 350
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
st3iny
force-pushed
the
chore/revert-moment-plugin-factory
branch
2 times, most recently
from
209973b to
7cd7201
Compare
st3iny
added
3. to review
We use Pinia now and we don't have to pass a store to the moment plugin anymore. The factory pattern is thus not required anymore. Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
chore/revert-moment-plugin-factory
branch
from
7cd7201 to
17208bd
Compare
st3iny
changed the title
SebastianKrupinski
approved these changes
Aug 25, 2025
Contributor
SebastianKrupinski
left a comment
SebastianKrupinski
left a comment
There was a problem hiding this comment.
Tested, Everything seems to work correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use Pinia now and we don't have to pass a store to the moment plugin anymore. The factory pattern is thus not required anymore.